From owner-p4-projects@FreeBSD.ORG  Mon Jul 13 14:09:34 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 16A9F1065670; Mon, 13 Jul 2009 14:09:34 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA978106564A
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 14:09:33 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B901D8FC17
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 14:09:33 +0000 (UTC)
	(envelope-from syl@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n6DE9XK9002339
	for <perforce@FreeBSD.org>; Mon, 13 Jul 2009 14:09:33 GMT
	(envelope-from syl@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n6DE9Xik002337
	for perforce@freebsd.org; Mon, 13 Jul 2009 14:09:33 GMT
	(envelope-from syl@FreeBSD.org)
Date: Mon, 13 Jul 2009 14:09:33 GMT
Message-Id: <200907131409.n6DE9Xik002337@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	syl@FreeBSD.org using -f
From: Sylvestre Gallon <syl@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 166007 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2009 14:09:34 -0000

http://perforce.freebsd.org/chv.cgi?CH=166007

Change 166007 by syl@syl_pablo on 2009/07/13 14:09:03

	remove isochronous code. This Ip does not support isochronous.
	Call s3c24dci_device_done in s3c24dci_device_xxx_close.

Affected files ...

.. //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#6 edit

Differences ...

==== //depot/projects/soc2009/syl_usb/src/sys/dev/usb/controller/s3c24xxdci.c#6 (text+ko) ====

@@ -176,6 +176,7 @@
 static void
 s3c24dci_device_ctrl_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -211,6 +212,7 @@
 static void
 s3c24dci_device_bulk_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -246,6 +248,7 @@
 static void
 s3c24dci_device_intr_close(struct usb_xfer *xfer)
 {
+	s3c24dci_device_done(xfer, USB_ERR_CANCELLED);
 	return ;
 }
 
@@ -269,41 +272,6 @@
 };
 
 /*
- * s3c24xxdci isochronous support
- */
-
-static void
-s3c24dci_device_isoc_fs_open(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_close(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_start(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-static void
-s3c24dci_device_isoc_fs_enter(struct usb_xfer *xfer)
-{
-	return ;
-}
-
-struct usb_pipe_methods s3c24dci_device_bulk_methods = {
-	.open = s3c24dci_device_isoc_fs_open,
-	.close = s3c24dci_device_isoc_fs_close,
-	.enter = s3c24dci_device_isoc_fs_enter,
-	.start = s3c24dci_device_isoc_fs_start,
-};
-
-/*
  * USB FN interface
  */
 
@@ -511,9 +479,6 @@
 		case UE_INTERRUPT:
 			ep->methods = &s3c24dci_device_intr_methods;
 			break ;
-		case UE_ISOCHRONOUS:
-			ep->methods = &s3c24dci_device_isoc_fs_methods;
-			break ;
 		case UE_BULK:
 			ep->methods = &s3c24dci_device_bulk_methods;
 			break ;