Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Dec 2016 11:35:59 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r308789 - head/sys/conf
Message-ID:  <CAPyFy2DMCyyLadvZtt1mTPcUyMMG8AdMfyC9kAHzyXhVx2Vt%2BA@mail.gmail.com>
In-Reply-To: <201611180013.uAI0DU57087971@repo.freebsd.org>
References:  <201611180013.uAI0DU57087971@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17 November 2016 at 19:13, Gleb Smirnoff <glebius@freebsd.org> wrote:
> Author: glebius
> Date: Fri Nov 18 00:13:30 2016
> New Revision: 308789
> URL: https://svnweb.freebsd.org/changeset/base/308789
>
> Log:
>   If FreeBSD source tree is a subproject of a bigger project, then .git or
>   .hg may reside above FreeBSD sources root.  Provide function findvcs()
>   that will climb up and seek for presence of a VCS directory.

This can incorrectly find an unrelated .git directory and provide a
git revision unrelated to the FreeBSD source being built. For example,
a build from my Subversion tree now reports "FreeBSD 12.0-CURRENT #2
ad3f46a(master)" instead of "FreeBSD 12.0-CURRENT #5 r310482M".

Can you explain your use case in a little more detail so that I can
avoid breaking it with a change here? Do you commit FreeBSD snapshots
into the "bigger project"?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DMCyyLadvZtt1mTPcUyMMG8AdMfyC9kAHzyXhVx2Vt%2BA>