From owner-freebsd-hackers@FreeBSD.ORG Sat Nov 2 23:36:28 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EDAA1611 for ; Sat, 2 Nov 2013 23:36:28 +0000 (UTC) (envelope-from bounces+73574-4a99-freebsd-hackers=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id 9DA9A2EFD for ; Sat, 2 Nov 2013 23:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=aHUQW2P1BavsxIo44tOy3i6Bg/w=; b=Z8IUZKyuY6VemcBGU3 1k6k6CkpaZeTt1q6Qv9fcXQN+4DbcKMLXJQoqb+N9R4O5T50mVJEw9BuReGGIanV Ssl+e8Imhj0GXBDAzDn/XnacrTDyFvBBcWeiRaf/qBjSXuMPIckOS2S3ihOW/o07 x0diNgS/K88JyLjtBEOqrxR/s= Received: by mf90 with SMTP id mf90.19231.52758C7B1 Sat, 02 Nov 2013 23:36:27 +0000 (GMT) Received: from mail.tarsnap.com (unknown [10.60.208.13]) by mi48 (SG) with ESMTP id 1421b2cc238.209a.1c1ece for ; Sat, 02 Nov 2013 18:36:27 -0500 (CST) Received: (qmail 81164 invoked from network); 2 Nov 2013 23:36:26 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 2 Nov 2013 23:36:26 -0000 Received: (qmail 32735 invoked from network); 2 Nov 2013 23:34:55 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 2 Nov 2013 23:34:55 -0000 Message-ID: <52758C1F.9080601@freebsd.org> Date: Sat, 02 Nov 2013 16:34:55 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: dt71@gmx.com, freebsd-hackers@freebsd.org Subject: Re: Automated submission of kernel panic reports References: <526F8EB3.1040205@freebsd.org> <5271A465.2030206@gmx.com> <5275888E.6010806@freebsd.org> <52758BCD.1000307@gmx.com> In-Reply-To: <52758BCD.1000307@gmx.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SG-EID: W2XBZA0V/n0voZZ6SjDkgjXvzGvkLIaljy40FLIRIHTVMXCc7ynl2WKQUz0qqp0cTlIbOM/0L54z4Oz1eEZl8DslsTTWIKJRulcn6xziG1crSjXwfuyS+f+VT2/jPI7Q81AzvWanu4KJ+7sAbF1lSp3yvHXTKbLf4lFE69tm3dY= X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Nov 2013 23:36:29 -0000 On 11/02/13 16:33, dt71@gmx.com wrote: > Colin Percival wrote, On 11/03/2013 00:19: >> On 10/30/13 17:29, dt71@gmx.com wrote: >>> I very much dislike the non-use of double quotes around variable expansions and >>> things like that in the shell code. >> >> Is there anywhere in particular you think this is dangerous? > > No, but you never know... especially with non-standard system setups. Quite true. I've committed an update including paranoid quoting. Let me know if you see anything I missed. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid