From nobody Thu Oct 26 20:21:59 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SGcdz3htXz4yF4N; Thu, 26 Oct 2023 20:21:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SGcdz36nVz3RGP; Thu, 26 Oct 2023 20:21:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698351719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XE2KSkIKeTUrSONsXV9hWNEtB+kh7CGxRM2oBsS0fyM=; b=coFJZ4z4MuhI2qtYnyXAh/Bh6y1KGHaAmgRUbUASn8jPkgHfB1YTxxxZ2Yfil2atqP/OSk mPcXkWwpiMRtsX+4ww/zMz2GxyADL5WKoqWI7m7AS4HEEfBbEvEfPtyU9Uqr8uj5JQ1JpN Dz8EFnGXy/R2zHyz280MjI1uT5e286agWFJAlu33vLALV2vDw5qBWnkHwjk7VfT5xYIe+T ppise6rI64lV5w6Zga7kb1PYqr84KRYop5yvZ1km9nHu7NSnTE2WA9AjNPl9OMPBVcWCl7 R+fKjXR9bXR2dBwawAmFHJClTLVdHxLCtkYaeQ3D27p1uVgfhGiLZyy3WGEUpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698351719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XE2KSkIKeTUrSONsXV9hWNEtB+kh7CGxRM2oBsS0fyM=; b=rbcB8/VgmR7FnmMyk5om4G5aFUngAb9ZxrGdb5aBJdDNKKQzMvSVzlHieWO9yWpMZenL0+ N4Pkxj8QIZNx+HqsEPalilXv5miAk13w5wMYNkC/cjVJ4ovZ7vq+8N8WG5QVCgWAamiAys fLRlzXE+qARI+ug5BGpzY/Okc63c6RvKdNQZjzyVotm4+NmlIjkyFEyzFDbP49Uj5qK1ug 98O6CreKlg3sbS9sjRn35Exjgb0NveIZkBhF2c+Sy7aB8Wj2E1fTert3a39qjG4iLTrIsd 8HaykuI2Y4yEHmXe9W8E9Xiaaxi9e3l266Q1Tq90/5muA6clcOG6TNpXfGQoSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698351719; a=rsa-sha256; cv=none; b=jSknGDJ/+7gnniDyZ1OmKwNrMHjabb28r6fIW+PDQZwALrIQp7Rmhi8Vt9OIQ5wvih41Pl 1ixi2O2qWqRE9hseddbJHuQoNsV8xNrOtglMhHf3D+x6XGvmSV5cp7k+Aer6lYoZ9PxXZk Ymt86Bh/T8LQY8qN6TOZHhwg3mJ09TJkfZLmTtG/t8kU4nOa6J38syGzK2pi+LFKSnl1/7 z9j7cMPyeSOoB+fCg8fvev+C4vkPB7RcDTIzQaq4oA9M9boGW69taL4reIsRMQgnA46lTH z9uP2psgnquM2B3kFY143lMEJv9vllR47Ewy6Eof5fWKgXEAPM6Bu0g7Tzb7+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SGcdz29PyzlFQ; Thu, 26 Oct 2023 20:21:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39QKLxSJ070976; Thu, 26 Oct 2023 20:21:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39QKLxm9070973; Thu, 26 Oct 2023 20:21:59 GMT (envelope-from git) Date: Thu, 26 Oct 2023 20:21:59 GMT Message-Id: <202310262021.39QKLxm9070973@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 6f1ccbd58790 - stable/14 - bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6f1ccbd587907c5eaf05ddd77d1e9f5e16b7aedc Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=6f1ccbd587907c5eaf05ddd77d1e9f5e16b7aedc commit 6f1ccbd587907c5eaf05ddd77d1e9f5e16b7aedc Author: Gleb Smirnoff AuthorDate: 2023-10-26 09:59:21 +0000 Commit: Mark Johnston CommitDate: 2023-10-26 20:21:22 +0000 bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS) ioctl(2)'s with integer argument shall pass command argument by value, not by pointer. The ioctl(2) manual page is not very clear about that. See sys/kern/sys_generic.c:sys_ioctl() near IOC_VOID. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D42366 Fixes: fd8b9c73a5a63a7aa438a73951d7a535b4f25d9a (cherry picked from commit f407a72a506d2630d60d9096c42058f12dff874e) --- usr.sbin/bhyve/net_backends.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/net_backends.c b/usr.sbin/bhyve/net_backends.c index 99781cfdcbb6..de6afab53854 100644 --- a/usr.sbin/bhyve/net_backends.c +++ b/usr.sbin/bhyve/net_backends.c @@ -238,7 +238,7 @@ tap_init(struct net_backend *be, const char *devname, goto error; } - if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, &up)) { + if (ioctl(be->fd, VMIO_SIOCSIFFLAGS, up)) { WPRINTF(("tap device link up failed")); goto error; }