From owner-svn-src-all@FreeBSD.ORG Sat Apr 5 18:41:08 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ABC167AA; Sat, 5 Apr 2014 18:41:08 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98D21F6F; Sat, 5 Apr 2014 18:41:08 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s35If8cv027383; Sat, 5 Apr 2014 18:41:08 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s35If88l027382; Sat, 5 Apr 2014 18:41:08 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201404051841.s35If88l027382@svn.freebsd.org> From: Edward Tomasz Napierala Date: Sat, 5 Apr 2014 18:41:08 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r264163 - head/sys/dev/iscsi X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2014 18:41:08 -0000 Author: trasz Date: Sat Apr 5 18:41:08 2014 New Revision: 264163 URL: http://svnweb.freebsd.org/changeset/base/264163 Log: Remove hack to pass STAILQ to a function and do it properly instead. Sponsored by: The FreeBSD Foundation Modified: head/sys/dev/iscsi/icl.c Modified: head/sys/dev/iscsi/icl.c ============================================================================== --- head/sys/dev/iscsi/icl.c Sat Apr 5 18:32:40 2014 (r264162) +++ head/sys/dev/iscsi/icl.c Sat Apr 5 18:41:08 2014 (r264163) @@ -105,6 +105,8 @@ static volatile u_int icl_ncons; #define ICL_CONN_LOCK_ASSERT(X) mtx_assert(X->ic_lock, MA_OWNED) #define ICL_CONN_LOCK_ASSERT_NOT(X) mtx_assert(X->ic_lock, MA_NOTOWNED) +STAILQ_HEAD(icl_pdu_stailq, icl_pdu); + static void icl_conn_fail(struct icl_conn *ic) { @@ -831,9 +833,8 @@ icl_pdu_finalize(struct icl_pdu *request } static void -icl_conn_send_pdus(struct icl_conn *ic, void *fts) +icl_conn_send_pdus(struct icl_conn *ic, struct icl_pdu_stailq *queue) { - STAILQ_HEAD(, icl_pdu) *queue = fts; /* XXX */ struct icl_pdu *request, *request2; struct socket *so; size_t available, size, size2; @@ -943,7 +944,7 @@ static void icl_send_thread(void *arg) { struct icl_conn *ic; - STAILQ_HEAD(, icl_pdu) queue; + struct icl_pdu_stailq queue; ic = arg;