From owner-freebsd-chromium@FreeBSD.ORG Thu Dec 6 20:51:11 2012 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 78D2EA05 for ; Thu, 6 Dec 2012 20:51:11 +0000 (UTC) (envelope-from evanm@google.com) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by mx1.freebsd.org (Postfix) with ESMTP id E10D68FC0C for ; Thu, 6 Dec 2012 20:51:10 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id 12so4000958wgh.31 for ; Thu, 06 Dec 2012 12:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1tpsGnlH+zOvsYWXi7J8GR7N52lt8LSgGhDOeyHl2Pw=; b=oASInODdy1a6DR5AzVOtN0u+No0BBKyfRSsOwifafLBwCjxVDXSzTjkhYFpv0RHXK1 vG0rtDWXqMbDV+tF30W3SM6HkCXxI54bRZqtEuiVH/V3ARgbnqYq8Xh627NSt+EBzfcC ijYDfQM20b9/6JWaJ2LLm/2vMCFfnolALl59KgOVpPs+keY2f13HWhr/3T0OhiIcloOM y3UB7Isht4BDsMEKfPGF1HPmcY/m0LLiSWKHCza9ug2mnyhn7qcW87KHecPXN8aXkRkL ebhPZXS7br6X/6pyDgLEI0ZAOxjDsd3SLP2gOtTztywafSE8RGNpUogTKPGXtPcuQZTq DpxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1tpsGnlH+zOvsYWXi7J8GR7N52lt8LSgGhDOeyHl2Pw=; b=RRv5nw994Wf7A2ZnndHnUYkKcsGfDXcZN8BRZ23+fr129K+75Kq63sNefDihsgDu9t /lNpOAHeRu5D+DjCp48hYQ1dqDKPDgAWayU7TyRIN7aONSPhpnKR3AFXcrAGLQvZFiuc h7JHmXT7Mcc2TH8kEWARzvnH4Q8TCSgKI8czc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=1tpsGnlH+zOvsYWXi7J8GR7N52lt8LSgGhDOeyHl2Pw=; b=VjZw/KrkF/ThbgGyQnRBnkYHsiiLQbLeNL09c/91xB8KinLqed1sjAyiODak88/oz+ su2gWzGG3ZY0QEjgV4xZpG3Ly5K8wfe0wXQ92tZCjkPcoQJEAfwNYGIR7yuAIiFGqXn7 sVnLcIO3wrDXXvxS/4EFDu6+5kPsxHfqDWPsazzH9ZU2XW3rTc2urhEQ8WALl1hEuTuE IBvYiS7oiLBCnbc9bBHRLqCOVbJfRO0PNmwwJsDeag4ptr32S06pyP2tF4xXxmGUVBQO jec91vWbB2pfxZ3slU/FmSqZpiUfGLFqWr5Z9T1OFA4fLQ2hJsgUMzMvAKl4a8KZP5eg 2iSw== MIME-Version: 1.0 Received: by 10.180.8.133 with SMTP id r5mr4619975wia.7.1354827069533; Thu, 06 Dec 2012 12:51:09 -0800 (PST) Sender: evanm@google.com Received: by 10.216.151.35 with HTTP; Thu, 6 Dec 2012 12:51:09 -0800 (PST) In-Reply-To: <20121206004945.7ec2a1f1@shibato> References: <20121206004945.7ec2a1f1@shibato> Date: Thu, 6 Dec 2012 12:51:09 -0800 X-Google-Sender-Auth: n5ce3f_4-enE1P0vqH-vcKkFFcU Message-ID: Subject: Re: WIP: Wi-fi Geolocation Provider From: Evan Martin To: "J.R. Oldroyd" X-Gm-Message-State: ALoCoQnOd5lC3qCtYEthO4ljMBHD3gBIacpjspeHrRnjNiHQw5PnEb5S4yXLPfdtvUfxVeaaWF4Ya/96AiSqsYo2j1gao+4HBkSCZyv4a6V2BtGhETZd1i56p953WR/D7JsdzHJw8hWwEMAqIoVpBmZSP6+i4zqUpCsGfDBxh3BRBfrsspyG24Dykr6k/0CqFaf3SLxjfHSgUe1ekB+G9YqcVO7dUQDpzg== Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-chromium@freebsd.org X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2012 20:51:11 -0000 (I used to work on Chrome, though not in this area. Your patch looks right enough to me. If you ever sent it upstream they'd want you to match the surrounding code style, stuff like two-space tabs and variable declarations where they're used instead of at the top of the functions.) To diagnose the problem: Does your DefaultFactoryFunction() implementation ever get called? Before your patch, what code was running when a page tried to geolocate? Your patch seems to be missing some minus lines where it removes the fallback code that was running for FreeBSD before. In particular, it looks like this file is providing some default empty implementation that you might need to disable (toggle some ifdefs): http://code.google.com/searchframe#OAMlx_jo-ck/src/content/browser/geolocation/empty_device_data_provider.cc It's not clear to me why your code even compiles with two implementations of this function, but this Chrome code seems overly tricky for what I'd naively think it needs to do so maybe there's some good reason. On Wed, Dec 5, 2012 at 9:49 PM, J.R. Oldroyd wrote: > It seems that Google's Geolocation Service lookups done using an > IPv6 address results in a location that is far, far, far away from > where you really are, and even lookups using IPv4 addresses are often > several km off. Since I am increasingly running into web pages that > want to "help me better" based on my location, it seems a more > accurate lookup is needed. > > So... I have knocked together a wifi_data_provider_freebsd.cc that > gets your list of wi-fi APs so that the geolocation lookup can be > done using the wi-fi AP information. > > The wi-fi AP code was tested and works as a stand-alone program. > > Now, I am not really a C++ guy and I am far from up-to-speed on > chromium's object methods and how to hook this in so the browser > actually finds and uses it. I could use some help with that. > > I've put what I have so far, and some additional details, here: > > http://opal.com/jr/freebsd/ports/www/chromium/files/ > > Anyone who cares to help integrate this into chromium, feel free to > grab the files from that page, and figure out what I've missed with > getting this properly hooked in. Please email me with any improvements > you can offer. > > -jr > _______________________________________________ > freebsd-chromium@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-chromium > To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.org > " >