From owner-cvs-all@FreeBSD.ORG Thu Sep 28 07:22:48 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 479B516A40F; Thu, 28 Sep 2006 07:22:48 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from av11-1-sn2.hy.skanova.net (av11-1-sn2.hy.skanova.net [81.228.8.183]) by mx1.FreeBSD.org (Postfix) with ESMTP id 853ED43D5D; Thu, 28 Sep 2006 07:22:41 +0000 (GMT) (envelope-from joel@FreeBSD.org) Received: by av11-1-sn2.hy.skanova.net (Postfix, from userid 502) id 590813847E; Thu, 28 Sep 2006 09:22:40 +0200 (CEST) Received: from smtp4-2-sn2.hy.skanova.net (smtp4-2-sn2.hy.skanova.net [81.228.8.93]) by av11-1-sn2.hy.skanova.net (Postfix) with ESMTP id 4AE6438455; Thu, 28 Sep 2006 09:22:40 +0200 (CEST) Received: from dude.automatvapen.se (81-229-112-193-no21.tbcn.telia.com [81.229.112.193]) by smtp4-2-sn2.hy.skanova.net (Postfix) with ESMTP id 2661737E46; Thu, 28 Sep 2006 09:22:40 +0200 (CEST) From: Joel Dahl To: Eric Anholt In-Reply-To: <1159423952.671.11.camel@localhost> References: <200609270638.k8R6csJ0044991@repoman.freebsd.org> <1159423952.671.11.camel@localhost> Content-Type: text/plain Date: Thu, 28 Sep 2006 09:22:40 +0200 Message-Id: <1159428160.671.35.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci agp_i810.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2006 07:22:48 -0000 On Thu, 2006-09-28 at 08:12 +0200, Joel Dahl wrote: > On Wed, 2006-09-27 at 06:38 +0000, Eric Anholt wrote: > > anholt 2006-09-27 06:38:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/pci agp_i810.c > > Log: > > Add support for 945G/GM AGP chipsets. > > > > The key problem was that the aperture size detection using the MSAC bit > > doesn't work -- the bit appears to be set even when it shouldn't be. Linux > > takes a different approach, testing for a bit of the GMADR (PCIR_BAR(2)) being > > set. However, as I don't think that's a safe way to test aperture size, we > > just allocate the resource and check its size. This also pointed out that > > agp_generic_attach hadn't been allocating our aperture resource, which may > > have caused problems in some cases. > > > > Also corrected is a minor copy-and-pasteo in an error case. > > Hmm, I have a HP NX7400 laptop with an Intel i945 chipset, and it's > running a very fresh current (GENERIC, no changes made whatsoever). > However, I see the following in my dmesg when I start X (I *think* it > started appearing just after your commit to agp_i810.c): Ok, I can confirm that reverting back to revision 1.38 of agp_i810.c fixes the problem. -- Joel