From owner-freebsd-threads@FreeBSD.ORG  Mon Feb  4 20:13:24 2008
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1FB9E16A503
	for <freebsd-threads@freebsd.org>; Mon,  4 Feb 2008 20:13:24 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outE.internet-mail-service.net (outE.internet-mail-service.net
	[216.240.47.228])
	by mx1.freebsd.org (Postfix) with ESMTP id 02EE313C46B
	for <freebsd-threads@freebsd.org>; Mon,  4 Feb 2008 20:13:23 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP;
	Mon, 04 Feb 2008 12:13:23 -0800
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id 9B9501270C8;
	Mon,  4 Feb 2008 12:13:22 -0800 (PST)
Message-ID: <47A771E3.5080403@elischer.org>
Date: Mon, 04 Feb 2008 12:13:23 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <200801240850.m0O8o2JQ023500@freefall.freebsd.org>
	<4798564B.7070500@elischer.org>
	<Pine.GSO.4.64.0801240957550.16059@sea.ntplx.net>
	<20080128185830.B56811@fledge.watson.org>
In-Reply-To: <20080128185830.B56811@fledge.watson.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Daniel Eischen <deischen@freebsd.org>,
	Gary Stanley <gary@velocity-servers.net>, re@freebsd.org,
	freebsd-threads@freebsd.org
Subject: Re: threads/119920: fork broken in libpthread
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2008 20:13:24 -0000

Robert Watson wrote:
> 
> On Thu, 24 Jan 2008, Daniel Eischen wrote:
> 
>>> dan what IS the fix for this?  I assume you must have fixed it in 
>>> -current/7
>>
>> You want cvs diff -u -r1.126 -r1.128 src/lib/libkse/thread/thr_kern.c. 
>> The WARNS'ify diffs are not necessary, so it should look something 
>> like shown below.  Probably an MFC of all of libkse (minus jasone's 
>> malloc changes) should be done to -7 and -6.
> 
> Should the patch be considered for an errata notice for 6.x?  Should we 
> be trying to MFC this to 7.x for inclusion with 7.0 or does it need more 
> time to shake out and should potentially be a 7.0 errata notice or just 
> appear in 7.1?

I have MFC'd this to RELENG_6 RELENG_7 and RELENG_7_0
with blessing from kensmith.
We will add an errata for 6.3 and maybe even put it in the 6.3 branch.

I have seen -current machines actually crash (the whole machine) 
without this patch but haven't figured out the mechanism yet.
(I have one in the lab in this state now.. will go look at it soon)(

> 
> Robert N M Watson
> Computer Laboratory
> University of Cambridge