From owner-svn-src-head@freebsd.org Sat Apr 22 21:09:41 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08CD0D4B35D; Sat, 22 Apr 2017 21:09:41 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5E4CDBD; Sat, 22 Apr 2017 21:09:40 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3ML9aWB047900; Sat, 22 Apr 2017 14:09:36 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3ML9ahr047899; Sat, 22 Apr 2017 14:09:36 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201704222109.v3ML9ahr047899@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r317290 - head/tools/regression/geom_gpt In-Reply-To: <3238ED82-1FAA-4E7C-81B9-A9E9E417E860@gmail.com> To: "Ngie Cooper (yaneurabeya)" Date: Sat, 22 Apr 2017 14:09:36 -0700 (PDT) CC: rgrimes@freebsd.org, Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 21:09:41 -0000 -- Start of PGP signed section. [ Charset UTF-8 unsupported, converting... ] > > > On Apr 22, 2017, at 13:06, Rodney W. Grimes wrote: > > > >> Author: ngie > >> Date: Sat Apr 22 20:00:52 2017 > >> New Revision: 317290 > >> URL: https://svnweb.freebsd.org/changeset/base/317290 > >> > >> Log: > >> Fix -Wimplicit-function-declaration compilation warning by moving libgeom.h > >> #include below the stdio.h #include. > >> > >> gctl_dump(3) needs stdio.h, per reasoning noted in r317289. > >> > >> MFC after: 5 weeks > >> PR: 218809 > >> Submitted by: Chang-Hsien Tsai > >> Sponsored by: Dell EMC Isilon > >> > >> Modified: > >> head/tools/regression/geom_gpt/test.c > >> > >> Modified: head/tools/regression/geom_gpt/test.c > >> ============================================================================== > >> --- head/tools/regression/geom_gpt/test.c Sat Apr 22 19:32:23 2017 (r317289) > >> +++ head/tools/regression/geom_gpt/test.c Sat Apr 22 20:00:52 2017 (r317290) > >> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$"); > >> > >> #include > >> #include > >> -#include > >> #include > >> #include > >> #include > >> #include > >> #include > >> +#include > > #include /* This is not in alphabetic order per r317289 */ > >> > >> struct retval { > >> struct retval *retval; > > > > Might it be a good idea to mark this in the test.c file as to why > > these are not sorted in order to prevent regressions of this in > > the future? > > Please see r317289. There was an omission in the documentation that allowed this to happen. I had seen that already when I made my post, that docuement is not going to stop someone from going "Oh, these are out of order I am going to sort them since I am here" They well then probably have issues due to your next statement about WARNS and go hum, what is that all about. And either investigate and hopefully find the right thing, or do more wrong things. When #includes are out of order for good reason the source code file should be market as such and not dependend on the near 0 likelyhood someone is going to go read a man page to find out why. > > This also won?t happen again given that the test is now being compiled with WARNS?= 6 :). > > -Ngie -- End of PGP section, PGP failed! -- Rod Grimes rgrimes@freebsd.org