From owner-svn-src-all@FreeBSD.ORG Sun Jun 13 17:26:23 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6A171065670; Sun, 13 Jun 2010 17:26:23 +0000 (UTC) (envelope-from kaiwang27@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id E5DB08FC1C; Sun, 13 Jun 2010 17:26:22 +0000 (UTC) Received: by wyb33 with SMTP id 33so3649032wyb.13 for ; Sun, 13 Jun 2010 10:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received :x-authentication-warning:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=RIHcAU+mxyyAWussD/gcYBK1AzUSQ/+NVp3vdHhWdkw=; b=t6GwZRfiKpWmU1CRRk1ja+kIn5Je8KzmRnBmGwlhpVOj4U4k/tcTuTSzh1JPATvCIQ 64BrXfY6PEY7VGAXe6EJnW/wgch02yr+JX6dRSnBh5ieOEIQY/FZ7GaaPwWAhSxi2sjb 86ngVP3PO2CIXtGVCDAlSTHAC63p62woilrdY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=x-authentication-warning:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; b=aUPHwUmDxbA/URhtlHcrOjgQaVQHrPnblZw4uI+qp12xl/6Z76aE1LZV7URHf8oKza JXCXi4+h4xvf+O5glhweGa3sSm592JXUjLY/wVRrK0Jw6Nri00vwyCGhtXoNtGOHcd5r Uoj8kifMOyD1Jp2bLUgS+8E3sdqOSU4UTJcCY= Received: by 10.227.152.194 with SMTP id h2mr4606598wbw.196.1276448569998; Sun, 13 Jun 2010 10:02:49 -0700 (PDT) Received: from localhost (81-233-38-26-no36.tbcn.telia.com [81.233.38.26]) by mx.google.com with ESMTPS id p17sm21649762wbe.2.2010.06.13.10.02.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 13 Jun 2010 10:02:48 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=localhost.my.domain) by localhost with esmtp (Exim 4.71 (FreeBSD)) (envelope-from ) id 1ONqa6-0002bW-J6; Sun, 13 Jun 2010 19:02:46 +0200 Received: (from kaiw@localhost) by localhost.my.domain (8.14.3/8.14.3/Submit) id o5DH2kVY010013; Sun, 13 Jun 2010 19:02:46 +0200 (CEST) (envelope-from kaiwang27@gmail.com) X-Authentication-Warning: localhost.my.domain: kaiw set sender to kaiwang27@gmail.com using -f Date: Sun, 13 Jun 2010 19:02:46 +0200 From: Kai Wang To: Steve Kargl Message-ID: <20100613170246.GE2541@viskning> References: <201006131058.o5DAwo4b004987@svn.freebsd.org> <20100613163710.GA62804@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20100613163710.GA62804@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209122 - head/lib/libelf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2010 17:26:24 -0000 On Sun, Jun 13, 2010 at 09:37:10AM -0700, Steve Kargl wrote: > On Sun, Jun 13, 2010 at 10:58:50AM +0000, Kai Wang wrote: > > Author: kaiw > > Date: Sun Jun 13 10:58:50 2010 > > New Revision: 209122 > > URL: http://svn.freebsd.org/changeset/base/209122 > > > > Log: > > * Improve compatibility with existing application code by permitting the > > use of `elf_getbase()` on non-archive members. This change is needed > > for gcc LTO (-flto) to work properly. > > * Style fix: paranthesize returned values. > > * Document the current behaviour of `elf_getbase()`. > > > > Tested by: gerald, Steve Kargl (original patch) > > Obtained from: elftoolchain > > MFC after: 3 days > > > > Modified: > > head/lib/libelf/elf_getbase.3 > > head/lib/libelf/elf_getbase.c > > Thanks. Unfortunately without the patch to elf_update.c, > gcc LTO will not work (ie., 'gcc -flto -o z a.o b.o' will > segfault). Any chance that the elf_update.c patch will be > committed; possibly as a conditional compilation. The patch to elf_update.c needs some more work before it can be committed. We've concluded that our libelf is indeed overly strict about data alignment inside sections, so the problem will be fixed eventually. A ticket[1] has been created to track this issue. Thanks, Kai [1] http://sourceforge.net/apps/trac/elftoolchain/ticket/264