Date: Mon, 1 Mar 2021 10:50:10 -0600 From: Kyle Evans <kevans@freebsd.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: Brandon Bergren <bdragon@freebsd.org>, Warner Losh <imp@bsdimp.com>, Kevin Bowling <kevin.bowling@kev009.com>, Jessica Clarke <jrtc27@freebsd.org>, Colin Percival <cperciva@tarsnap.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 0b7472b3d8d2 - main - Mount the EFI system partition (ESP) on newly-installed systems. Message-ID: <CACNAnaHkN5%2BskX4WUJuVhHoe11sp7iSeh9q9hg4jxrHBBCb_1Q@mail.gmail.com> In-Reply-To: <82f307a1-d7e2-0950-510d-148a1a7e61a2@freebsd.org> References: <202102232124.11NLOT27012354@gitrepo.freebsd.org> <dba58a1f-5eb0-da87-7d18-d930aa5d422a@freebsd.org> <CANCZdfoL3QFg9NvpkPW8pfVrNvUK-cTPD2ZGbBr2xxh-0dv=eA@mail.gmail.com> <dc61048c-2cfa-0ff5-0470-e93aa5233aae@freebsd.org> <583f83d8-c78b-d961-d2c5-9693bd36563b@freebsd.org> <743fd126-2077-49b1-9c85-7ccc61616b98@www.fastmail.com> <460ceb98-e0c1-42b3-8e3c-2587c5ce8398@www.fastmail.com> <F4E1978D-DE96-4082-885F-D6686A5D005C@freebsd.org> <CANCZdfpw1%2BsjHVPH4zahywMsLHJ1jKWbnd5A3RjGinu=nQFSGA@mail.gmail.com> <a30870ef-00b1-40b6-b378-033d8737c7e4@www.fastmail.com> <CANCZdfqPNf-RW=-T9qk5a4o-rX3CWFVGz0H_hTav-CqnW9JJ=Q@mail.gmail.com> <CAK7dMtD9k5FscvG754tLO6ZeTm5%2Bru87F06O8%2BH3bVJqVjf9iQ@mail.gmail.com> <CANCZdfrej=mY0uZnY4Cg0PxTtPjJdCUVsM2trBO83z--Qks7JA@mail.gmail.com> <8215cd95-6905-49da-ab07-65796845613c@www.fastmail.com> <c9c1db40-4aff-e0c6-284f-96a4c1482cd8@freebsd.org> <CACNAnaEJUL%2BkNbEYKVfWkt0A8gK26MkukST_PXYeK27Y_1ZrsA@mail.gmail.com> <82f307a1-d7e2-0950-510d-148a1a7e61a2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 1, 2021 at 10:45 AM Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > > > > On 3/1/21 11:42 AM, Kyle Evans wrote: > > On Mon, Mar 1, 2021 at 10:39 AM Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > >> > >> > >> On 2/28/21 3:44 PM, Brandon Bergren wrote: > >>> On Sun, Feb 28, 2021, at 2:25 PM, Warner Losh wrote: > >>>> Yes. I agree as well. I was just hoping to say just that: EFI is barely > >>>> theoretically possible, but in reality we'll likely never use it.... > >>>> > >>>> The net effect is that we don't want to install efi on powerpc on freebsd. > >>>> > >>>> Warner > >>>> > >>> Yeah. The code before the change excluded mips and powerpc platforms, and it should continue to do so instead of using the existence of a /boot/efi directory as the only clue. > >>> > >>> Currently bsdinstall bails out and leaves powerpc* in a half-installed state because the die in the uname case propagates to the main script, so it never runs the bits after the bootconfig. > >>> > >> So that was a deliberate choice to keep the list of places that know > >> about efi vs. non-EFI centralized. I'd prefer to just not make that > >> directory on systems where it doesn't apply rather than messing with the > >> installer. Do you know where it is being made? > >> -Nathan > > It's part of the hierarchy in ^/etc/mtree/BSD.root.dist > > > > Is there a reason it needs to be? The installer bits all make it when > needed already, so just removing it there seems like the simplest path. I can't think of a reason, as long as both the release(7) scripts and the installer create it as needed -- I note that vmimage.subr seems to create it itself, but arm.subr seems to get it wrong atm. It'll need to create /boot/efi for PART_SCHEME == GPT, and /boot/msdos should probably be scoped down to PART_SCHEME == MBR where it's used at the moment.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHkN5%2BskX4WUJuVhHoe11sp7iSeh9q9hg4jxrHBBCb_1Q>