From owner-freebsd-arch@FreeBSD.ORG Tue Feb 26 10:43:15 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 27249478; Tue, 26 Feb 2013 10:43:15 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id DCC0DADB; Tue, 26 Feb 2013 10:43:14 +0000 (UTC) Received: from ds4.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id E46BAAAB7; Tue, 26 Feb 2013 10:43:12 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id A66719A37; Tue, 26 Feb 2013 11:43:12 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Pawel Jakub Dawidek Subject: Re: Large Capsicum patch for review. References: <20130213025547.GA2025@garage.freebsd.pl> <20130213230221.GB1375@garage.freebsd.pl> <20130223221116.GR1377@garage.freebsd.pl> <5129ADC5.5040306@gmx.de> <512A2CA0.2050509@gmx.de> <20130224235936.GX1377@garage.freebsd.pl> <512B3DBB.4080909@gmx.de> <20130225215004.GA1375@garage.freebsd.pl> Date: Tue, 26 Feb 2013 11:43:12 +0100 In-Reply-To: <20130225215004.GA1375@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Mon, 25 Feb 2013 22:50:05 +0100") Message-ID: <867glvbbjz.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Christoph Mallon , freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 10:43:15 -0000 Pawel Jakub Dawidek writes: > I use size_t as this is preferred type for size, but I don't need size_t > for iterator, because I know the value will never need more than 16 > bits, so I use int as a more CPU-friendly type. Using int as an iterator can lead to warnings about signedness mismatch in loop conditions etc., so you should at the very least use unsigned int. Besides, size_t is equal to unsigned long on all platforms, so "CPU-friendly" is not a valid argument. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no