From owner-svn-ports-head@FreeBSD.ORG  Sun Aug  4 16:35:29 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 088D37CA; Sun,  4 Aug 2013 16:35:29 +0000 (UTC)
Date: Sun, 4 Aug 2013 16:35:29 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Subject: Re: svn commit: r324179 - in head/devel: . acme
Message-ID: <20130804163529.GA22214@FreeBSD.org>
References: <201308030733.r737XGXd008385@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201308030733.r737XGXd008385@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Aug 2013 16:35:29 -0000

On Sat, Aug 03, 2013 at 07:33:16AM +0000, Jason Helfman wrote:
> New Revision: 324179
> URL: http://svnweb.freebsd.org/changeset/ports/324179
> 
> +BUILD_WRKSRC =	${WRKSRC}/src

Stray space before =.

> +PLIST_FILES=	bin/acme \
> +		%%DATADIR%%/6502 \
> +		%%DATADIR%%/6502/Help.txt \
> +		%%DATADIR%%/6502/std.a \
> +		%%DATADIR%%/65816 \
> +		%%DATADIR%%/65816/Help.txt \
> +		%%DATADIR%%/65816/std.a \
> +		%%DATADIR%%/Own \
> +		%%DATADIR%%/Own/Help.txt
> +PLIST_DIRSTRY=	%%DATADIR%%/6502 \
> +		%%DATADIR%%/65816 \
> +		%%DATADIR%%/Own \
> +		%%DATADIR%%

Typically using PLIST_* makes sense for short (like, five or so) entries;
in this case I would say that traditional pkg-plist should have been used.

> +post-patch-script:
> +.for i in CC CFLAGS
> +	@${REINPLACE_CMD} 's|${i}.*= |${i} ?= |g' ${WRKSRC}/src/Makefile
> +.endfor

Did you try to pass CC="${CC}" CFLAGS="${CFLAGS}" as MAKE_ARGS instead?

> +	${INSTALL_PROGRAM} ${WRKSRC}/src/acme ${PREFIX}/bin/${PORTNAME}

Trailing ${PORTNAME} is both unneeded and confusing here (it suggests
that ${PORTNAME} != acme).

> +.for dir in 6502 65816 Own
> +	@${MKDIR} ${DATADIR}/${dir}
> +.endfor
> +	${INSTALL_DATA} ${WRKSRC}/ACME_Lib/6502/* ${DATADIR}/6502
> +	${INSTALL_DATA} ${WRKSRC}/ACME_Lib/65816/* ${DATADIR}/65816
> +	${INSTALL_DATA} ${WRKSRC}/ACME_Lib/Own/* ${DATADIR}/Own
> +
> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}

This MKDIR call is unmuted, but previous and the next ones are.  This is
inconsistent and thus does not look good.

./danfe