From owner-freebsd-bugs  Sun Apr 22  8:10:13 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8E10637B424
	for <freebsd-bugs@hub.freebsd.org>; Sun, 22 Apr 2001 08:10:04 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f3MFA4F58087;
	Sun, 22 Apr 2001 08:10:04 -0700 (PDT)
	(envelope-from gnats)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
	by hub.freebsd.org (Postfix) with ESMTP id 1008B37B422
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Apr 2001 08:04:24 -0700 (PDT)
	(envelope-from marck@woozle.rinet.ru)
Received: (from marck@localhost)
	by woozle.rinet.ru (8.11.2/8.11.2) id f3MF4He24480;
	Sun, 22 Apr 2001 19:04:17 +0400 (MSD)
	(envelope-from marck)
Message-Id: <200104221504.f3MF4He24480@woozle.rinet.ru>
Date: Sun, 22 Apr 2001 19:04:17 +0400 (MSD)
From: marck@rinet.ru
Reply-To: marck@rinet.ru
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: gnu/26771: cvs checkout bug with existing val-tags and readonlyfs
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         26771
>Category:       gnu
>Synopsis:       cvs checkout bug with existing val-tags and readonlyfs
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 22 08:10:03 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Morozovsky <marck@rinet.ru>
>Release:        Various
>Organization:
Cronyx Plus LLC (RiNet ISP)
>Environment:
	cvs versions at least 1.10, 1.11

>Description:

When:

- repository is readonly, and
- there is CVSROOT/val-tags file, and
- you try to check out tree with valid tag, and
- this tag is not exist in CVSROOT/val-tags file

cvs exits with an error such as:

[checkout aborted]: cannot write /.../CVSROOT/val-tags: Read-only file system


>How-To-Repeat:

See description.


>Fix:

Just do not try to modify val-tags when readonlyfs is set:
                                                          
Index: src/contrib/cvs/src/tag.c
===================================================================
RCS file: /pub/FreeBSD/ncvs/src/contrib/cvs/src/tag.c,v
retrieving revision 1.1.1.6.2.1
diff -u -r1.1.1.6.2.1 tag.c
--- src/contrib/cvs/src/tag.c   2000/10/31 09:37:58     1.1.1.6.2.1
+++ src/contrib/cvs/src/tag.c   2001/04/22 14:15:48                     
@@ -868,7 +868,8 @@
        /* The tags is valid but not mentioned in val-tags.  Add it.  */
        datum value;

-       if (noexec)
+       /* Do not try to add tags if our repository is read-only */
+       if (noexec || readonlyfs)
        {
            if (db != NULL)
                dbm_close (db);


>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message