From owner-cvs-all Sat Jun 15 16:20: 5 2002 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 8ED2E37B411; Sat, 15 Jun 2002 16:19:55 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 03F6A81490; Sun, 16 Jun 2002 08:49:46 +0930 (CST) Date: Sun, 16 Jun 2002 08:49:46 +0930 From: Greg 'groggy' Lehey To: Alexey Zelkin , Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/calendar Makefile Message-ID: <20020615231946.GA65995@wantadilla.lemis.com> References: <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614191040.H2820-100000@gamplex.bde.org> <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614121629.A26139@ark.cris.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020614191040.H2820-100000@gamplex.bde.org> <20020614121629.A26139@ark.cris.net> User-Agent: Mutt/1.3.99i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Friday, 14 June 2002 at 12:16:29 +0300, Alexey Zelkin wrote: > On Thu, Jun 13, 2002 at 02:22:00PM -0700, Greg Lehey wrote: >> grog 2002/06/13 14:22:00 PDT >> >> Modified files: >> usr.bin/calendar Makefile >> Log: >> beforeinstall target: >> >> - Remove superfluous ; >> - create destination directories if they don't exist. > > This is incorrect. It's a task of mtree(8) to create directory > hierarchy, and IIRC it was discussed number of times before. Possibly I'm missing some vital information here, but how does mtree get invoked from the individual Makefile? It should be possible to do: cd /usr/src/usr.bin/calendar make all install This didn't work, because the French calendar entries had been added since the last 'make world'. It doesn't seem reasonable for 'make install' in this directory to behave differently from 'make installworld' in /usr/src. On Friday, 14 June 2002 at 19:18:01 +1000, Bruce Evans wrote: > On Thu, 13 Jun 2002, Greg Lehey wrote: > >> grog 2002/06/13 14:22:00 PDT >> >> Modified files: >> usr.bin/calendar Makefile >> Log: >> beforeinstall target: >> >> - Remove superfluous ; >> - create destination directories if they don't exist. > > It is a style bug at best to create destination directories directly, > especially using mkdir -p instead of install -d to ensure having little > control over the directories' attributes. I tried install -d first, and got problems which suggested that I was misunderstanding its use. Here's the rule I had: .for lang in ${INTER} ${INSTALL} -d -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \ ${.CURDIR}/calendars/${lang}/calendar.* \ ${DESTDIR}${SHAREDIR}/calendar/${lang} .endfor This generated: install: /src/FreeBSD/5.0-CURRENT/src/usr.bin/calendar/calendars/de_DE.ISO8859-1/calendar.all exists but is not a directory How do I get around this issue? Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message