Date: Sun, 4 Nov 2012 15:09:52 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: portmgr@FreeBSD.org, Max Khon <fjoe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Remove unnecessary change to Mk/bsd.port.mk (: svn commit: r303619 - head/Mk) Message-ID: <alpine.LNX.2.00.1211041507330.2266@tuna.site> In-Reply-To: <alpine.LNX.2.00.1209041827470.4718@trevally.site> References: <201209032047.q83Kl1dl041630@svn.freebsd.org> <alpine.LNX.2.00.1209041827470.4718@trevally.site>
next in thread | previous in thread | raw e-mail | index | archive | help
I understand Mk/bsd.port.mk is not applicable for maintainer
timeouts or I would have gone ahead and committed the patch
below.
Can you please have a look?
Thanks,
Gerald
On Wed, 5 Sep 2012, Gerald Pfeifer wrote:
>> +CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>> +.endif
>
> Really?
>
> Something looks fundamentally wrong if you have to do this under
> .if defined(USE_READLINE), at least past
>
> r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines
>
> Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV
>
> PR: 153625
> Submitted by: gerald
>
> How about the patch below?
>
> Gerald
>
> Index: bsd.port.mk
> ===================================================================
> --- bsd.port.mk (revision 303674)
> +++ bsd.port.mk (working copy)
> @@ -1708,7 +1708,6 @@
> LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline
> CPPFLAGS+= -I${LOCALBASE}/include
> LDFLAGS+= -L${LOCALBASE}/lib -lreadline
> -CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> .endif
> .endif
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1211041507330.2266>