From owner-svn-ports-all@FreeBSD.ORG  Sun Nov  4 14:09:50 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 4A9E9DCD;
 Sun,  4 Nov 2012 14:09:50 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 1778A8FC0C;
 Sun,  4 Nov 2012 14:09:50 +0000 (UTC)
Received: from [192.168.0.129] (vie-188-118-240-184.dsl.sil.at
 [188.118.240.184])
 by ainaz.pair.com (Postfix) with ESMTPSA id 7F3E63F40F;
 Sun,  4 Nov 2012 09:09:48 -0500 (EST)
Date: Sun, 4 Nov 2012 15:09:52 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: portmgr@FreeBSD.org, Max Khon <fjoe@FreeBSD.org>
Subject: Remove unnecessary change to Mk/bsd.port.mk (: svn commit: r303619
 - head/Mk)
In-Reply-To: <alpine.LNX.2.00.1209041827470.4718@trevally.site>
Message-ID: <alpine.LNX.2.00.1211041507330.2266@tuna.site>
References: <201209032047.q83Kl1dl041630@svn.freebsd.org>
 <alpine.LNX.2.00.1209041827470.4718@trevally.site>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2012 14:09:50 -0000

I understand Mk/bsd.port.mk is not applicable for maintainer 
timeouts or I would have gone ahead and committed the patch
below.

Can you please have a look?

Thanks,
Gerald

On Wed, 5 Sep 2012, Gerald Pfeifer wrote:
>> +CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>> +.endif
> 
> Really?
> 
> Something looks fundamentally wrong if you have to do this under
> .if defined(USE_READLINE), at least past
> 
>   r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines
> 
>   Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV
> 
>   PR:             153625
>   Submitted by:   gerald
> 
> How about the patch below?
> 
> Gerald
> 
> Index: bsd.port.mk
> ===================================================================
> --- bsd.port.mk	(revision 303674)
> +++ bsd.port.mk	(working copy)
> @@ -1708,7 +1708,6 @@
>  LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
>  CPPFLAGS+=		-I${LOCALBASE}/include
>  LDFLAGS+=		-L${LOCALBASE}/lib -lreadline
> -CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>  .endif
>  .endif
>