From owner-cvs-src@FreeBSD.ORG  Wed Jun 27 19:42:04 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6F87D16A46E;
	Wed, 27 Jun 2007 19:42:04 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail18.syd.optusnet.com.au (mail18.syd.optusnet.com.au
	[211.29.132.199])
	by mx1.freebsd.org (Postfix) with ESMTP id E471313C45B;
	Wed, 27 Jun 2007 19:42:03 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c220-239-235-248.carlnfd3.nsw.optusnet.com.au
	(c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248])
	by mail18.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	l5RJfi7B010371
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 28 Jun 2007 05:41:47 +1000
Date: Thu, 28 Jun 2007 05:41:44 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Xin LI <delphij@delphij.net>
In-Reply-To: <46826A8C.8070908@delphij.net>
Message-ID: <20070628053644.A74728@delplex.bde.org>
References: <200706261910.l5QJALb8093717@repoman.freebsd.org>
	<20070627093610.GU2268@deviant.kiev.zoral.com.ua>
	<20070627113859.N64822@knop-beagle.kn.op.dlr.de>
	<20070627101148.GB44554@nagual.pp.ru> <46826A8C.8070908@delphij.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: src-committers@FreeBSD.org, Harti Brandt <harti@FreeBSD.org>,
	Andrey Chernov <ache@nagual.pp.ru>, cvs-all@FreeBSD.org,
	cvs-src@FreeBSD.org, Kostik Belousov <kostikbel@gmail.com>
Subject: Re: cvs commit: src/share/mk sys.mk
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2007 19:42:04 -0000

On Wed, 27 Jun 2007, Xin LI wrote:

> Andrey Chernov wrote:
>> I just sent this cross-building compatible variant to re@ for approve:
>>
>> --- sys.mk.orig	2007-06-27 14:04:15.000000000 +0400
>> +++ sys.mk	2007-06-27 14:04:33.000000000 +0400
>> @@ -35,7 +35,7 @@
>>  CFLAGS		?=	-O
>>  .else
>>  CC		?=	cc
>> -CFLAGS		?=	-O2 -fno-strict-aliasing -fno-tree-vrp -pipe
>> +CFLAGS		?=	-O1 -fno-strict-aliasing -pipe
>>  .endif
>
> Nitpicking: I think -O1 implies no strict-aliasing.  So -O1 -pipe might
> be just Ok.

Still has a style bug: -O implies -O.  If changing it, back out the commit
that changed it from -O.  I still use -O in most cases since -O2 is just a
waste of time in most cases.

Bruce