From owner-freebsd-hackers@freebsd.org  Sat Jan 13 15:48:43 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B459AE6F6A3
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Sat, 13 Jan 2018 15:48:43 +0000 (UTC)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9028B6A47B;
 Sat, 13 Jan 2018 15:48:43 +0000 (UTC)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w0DFmX5o045588;
 Sat, 13 Jan 2018 07:48:33 -0800 (PST)
 (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd-rwg@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w0DFmW2b045587;
 Sat, 13 Jan 2018 07:48:32 -0800 (PST) (envelope-from freebsd-rwg)
From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201801131548.w0DFmW2b045587@pdx.rh.CN85.dnsmgr.net>
Subject: Re: 1 << 31 redux
In-Reply-To: <CAF6rxg=zRAR6AWgxcjijHPm6mA7BwmaimQ60=75qfUCjepogfg@mail.gmail.com>
To: Eitan Adler <lists@eitanadler.com>
Date: Sat, 13 Jan 2018 07:48:32 -0800 (PST)
CC: Warner Losh <imp@bsdimp.com>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>,
 Dimitry Andric <dim@freebsd.org>, Ed Schouten <ed@nuxi.nl>
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Mailman-Approved-At: Sat, 13 Jan 2018 17:05:07 +0000
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jan 2018 15:48:43 -0000

> On 11 January 2018 at 07:47, Warner Losh <imp@bsdimp.com> wrote:
> >
> >
> > If we can't get people to fix the warnings we have in the tree now
> > (especially the kernel), why enable new warnings that will just be ignored?
> >
> 
> We've been doing a reasonable job with warnings until now. Either way, at
> higher warnings levels we should add what we can.

Is not this 1U<<31 -> signed value really just sweeping the bigger
issue that we are using signed values in unsigned ways?

-- 
Rod Grimes                                                 rgrimes@freebsd.org