From owner-cvs-all Sun Mar 17 13:13:27 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.musha.org (daemon.musha.org [218.44.187.2]) by hub.freebsd.org (Postfix) with ESMTP id 0DDA837B404; Sun, 17 Mar 2002 13:13:22 -0800 (PST) Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32]) by mail.musha.org (Postfix) with ESMTP id 71C1C4D900; Mon, 18 Mar 2002 06:13:20 +0900 (JST) Date: Mon, 18 Mar 2002 06:13:20 +0900 Message-ID: <861yeiq4nj.wl@archon.local.idaemons.org> From: "Akinori MUSHA" To: Doug Barton Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: ports/net/bind9 Makefile distinfo pkg-plist In-Reply-To: <20020317123901.I3758-100000@master.gorean.org> References: <86k7sbc4pe.wl@archon.local.idaemons.org> <20020317123901.I3758-100000@master.gorean.org> User-Agent: Wanderlust/2.9.7 (Unchained Melody) SEMI/1.14.3 (Ushinoya) LIMIT/1.14.7 (Fujiidera) APEL/10.3 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Sun, 17 Mar 2002 12:49:37 -0800 (PST), Doug Barton wrote: > On Mon, 18 Mar 2002, Akinori MUSHA wrote: > > > At Sun, 17 Mar 2002 11:11:05 -0800 (PST), > > Doug Barton wrote: > > > Thank you for your suggestion. I used a simplified version of it > > > > It's okay but it looks somewhat redundant to put the version number > > three times in Makefile, > > I count two. PORTVERSION and ISCVERSION. Can you show me the > third? It's in DISTFILES. You can use ${ISCVERSION} in it. DISTFILES= bind-9.2.1rc1.tar.gz > > and you could remove a redundant '/' in the > > ${MASTER_SITE_RINGSERVER:...} line. > > I'm not sure what you mean by that. ${MASTER_SITE_RINGSERVER:S,%SUBDIR%,net/bind9/${ISCVERSION}/,} ~ This trailing '/' is redundant. > > +LATEST_LINK= bind9 > > I didn't miss it, frankly I'm not sure what it does. However, > by changing PORTNAME I'm sure that 'pkg_add bind' and 'pkg_add bind9' do > exactly what I want them to. It's fine. I just showed another solution in case you were thinking changing PORTNAME was an unwanted workaround. FYI, there is another way to add an arbitrary suffix to PKGNAME: the PKGNAMESUFFIX variable. > Frankly, while some of what the ports do currently is quite > elegant, in my opinion, too much of it tries too hard to be too clever, > and ends up just being hopelessly obfuscated. My version of the port may > not fit your idea of elegance, but it accomplishes the goals I had in > mind, and that's good enough for me. OK... I'm sorry if I sounded pushing. Next time I'll just simply inform you of a problem instead of issuing a verbose patch. -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "Somewhere out of a memory.. of lighted streets on quiet nights.." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message