From owner-freebsd-cvsweb@FreeBSD.ORG  Thu May  1 20:00:16 2003
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B65037B401; Thu,  1 May 2003 20:00:16 -0700 (PDT)
Received: from mail1.acecape.com (mail1.acecape.com [66.114.74.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3CCD143F93; Thu,  1 May 2003 20:00:14 -0700 (PDT)
	(envelope-from roy@panix.com)
Received: from panix.com (p67-13.acedsl.com [66.114.67.13])
	by mail1.acecape.com (8.12.9/8.12.9) with ESMTP id h4230DAd013757;
	Thu, 1 May 2003 23:00:13 -0400
Date: Thu, 1 May 2003 23:00:10 -0400
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
To: Khachaturov Vassilii <Vassilii.Khachaturov@comverse.com>
From: Roy Smith <roy@panix.com>
In-Reply-To: <6B1DF6EEBA51D31182F200902740436803B24F5B@mail-in.comverse.com>
Message-Id: <303ACB4B-7C4A-11D7-8CCF-0050E405C35A@panix.com>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.552)
cc: freebsd-cvsweb@freebsd.org
Subject: Re: Displaying line numbers ($preformat_in_markup)
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list [restricted posting]
	<freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 May 2003 03:00:17 -0000

What is the purpose of the $preformat_in_markup variable?  Looking at 
the source, I only see two places it's used.  One is in the big "use 
vars" block near the top of the file, the other is inside 
cvswebMarkup():

         } elsif ($preformat_in_markup) {
                print "<pre>";

                 # prefetch several lines
                 my @buf = head($filehandle);

                 my %d = scan_directives(@buf);

                 while (@buf || !eof($filehandle)) {
                         $_ = @buf ? shift @buf : <$filehandle>;

                         print spacedHtmlText($_, $d{'tabstop'});
                 }

If it's never mentioned anywhere else in the file, it seems to me that 
it can never be set and this is dead code.  Am I missing something?