From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 5 13:36:03 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F0FF106566B; Tue, 5 Jul 2011 13:36:03 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 48B068FC08; Tue, 5 Jul 2011 13:36:02 +0000 (UTC) Received: by pzk27 with SMTP id 27so4135285pzk.13 for ; Tue, 05 Jul 2011 06:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=iMyGFXLA2Vm3kk7hUioN8zjCIwQTUsmd2VE4/X0ZqCg=; b=VkOyngQ3GZOJi1WksEtgK0ize6In1kojghG5aUYGKpqlV2PB+EJ0gqx81zAL7NaZ7W Ta9S8rwDbNeudrP5F4FMLsxF/xM3ypXWmHSDcx3LoTAp13pPyGjZM8LHqrNd6riIi7UF CMUD63zOkKay54oPD4QxrzbiQR2ygvFQEyTqY= MIME-Version: 1.0 Received: by 10.68.50.9 with SMTP id y9mr9705084pbn.24.1309872962639; Tue, 05 Jul 2011 06:36:02 -0700 (PDT) Sender: rmh.aybabtu@gmail.com Received: by 10.68.57.4 with HTTP; Tue, 5 Jul 2011 06:36:02 -0700 (PDT) In-Reply-To: <4E12E358.80002@FreeBSD.org> References: <4E12E358.80002@FreeBSD.org> Date: Tue, 5 Jul 2011 15:36:02 +0200 X-Google-Sender-Auth: f3_91AR0QWxyXhlr9VOryeRtUXM Message-ID: From: Robert Millan To: Dimitry Andric Content-Type: multipart/mixed; boundary=bcaec5430590a3990a04a752908d Cc: freebsd-hackers@freebsd.org, Ed Maste Subject: Re: [PATCH] __FreeBSD_cc_version in X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2011 13:36:03 -0000 --bcaec5430590a3990a04a752908d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2011/7/5 Dimitry Andric : > As far as I can see, this code only gives warnings when compiled with > gcc 4.5 or higher, and when using the -Wundef flag. =C2=A0Isn't it easier= to > just remove the -Wundef flag here? Here's a patch to remove -Wundef. I think it's a bad idea however, IMHO it's better to fix the cause of the warning instead. --=20 Robert Millan --bcaec5430590a3990a04a752908d Content-Type: text/plain; charset=US-ASCII; name="wundef.diff" Content-Disposition: attachment; filename="wundef.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gpqwf2410 SW5kZXg6IHN5cy9jb25mL2tlcm4ubWsKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2NvbmYva2Vybi5tawko cmV2aXNpb24gMjIzNzM2KQorKysgc3lzL2NvbmYva2Vybi5tawkod29ya2luZyBjb3B5KQpAQCAt NSw3ICs1LDcgQEAKICMKIENXQVJORkxBR1M/PQktV2FsbCAtV3JlZHVuZGFudC1kZWNscyAtV25l c3RlZC1leHRlcm5zIC1Xc3RyaWN0LXByb3RvdHlwZXMgXAogCQktV21pc3NpbmctcHJvdG90eXBl cyAtV3BvaW50ZXItYXJpdGggLVdpbmxpbmUgLVdjYXN0LXF1YWwgXAotCQktV3VuZGVmIC1Xbm8t cG9pbnRlci1zaWduIC1mZm9ybWF0LWV4dGVuc2lvbnMgXAorCQktV25vLXBvaW50ZXItc2lnbiAt ZmZvcm1hdC1leHRlbnNpb25zIFwKIAkJLVdtaXNzaW5nLWluY2x1ZGUtZGlycyAtZmRpYWdub3N0 aWNzLXNob3ctb3B0aW9uCiAjCiAjIFRoZSBmb2xsb3dpbmcgZmxhZ3MgYXJlIG5leHQgdXAgZm9y IHdvcmtpbmcgb246Cg== --bcaec5430590a3990a04a752908d--