From owner-freebsd-arch@FreeBSD.ORG Sat Apr 12 19:41:41 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9EB751065671 for ; Sat, 12 Apr 2008 19:41:41 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 5B4BC8FC31 for ; Sat, 12 Apr 2008 19:41:41 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m3CJfeiJ004485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 12 Apr 2008 12:41:40 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <48011074.9060906@freebsd.org> Date: Sat, 12 Apr 2008 12:41:40 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Doug Rabson References: <200804121703.m3CH3StJ081660@chez.mckusick.com> <41ED3941-E5E6-45F0-B880-C1B2861FDE32@rabson.org> In-Reply-To: <41ED3941-E5E6-45F0-B880-C1B2861FDE32@rabson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist Cc: Kirk McKusick , arch@freebsd.org Subject: Re: VOP_LEASE X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2008 19:41:41 -0000 Doug Rabson wrote: > > On 12 Apr 2008, at 18:03, Kirk McKusick wrote: > >>> Date: Sat, 12 Apr 2008 02:13:15 -1000 (HST) >>> From: Jeff Roberson >>> To: arch@freebsd.org >>> Subject: VOP_LEASE >>> >>> As far as I can tell this has never been used. Unless someone can >>> show me >>> otherwise I'm going to go ahead and remove it. >>> >>> Thanks, >>> Jeff >> >> VOP_LEASE is used by NQNFS and NFSv4. It notifies them when a file >> is modified locally so that they know to update any outstanding >> leases (e.g., evict any write lease for the file and do callbacks >> for any read leases for the file). Deleting VOP_LEASE would break >> NFS big time. > > I think our NQNFS support might have been removed some time ago - I > can't see any calls to VOP_LEASE in the code right now. Something like > VOP_LEASE would certainly be useful for a hypothetical future NFSv4 > server. I believe that samba could use it too for its oplocks feature > which appears to be similar to NQNFS's leases and NFSv4's delegations. > Note NQNFS is long dead (netbsd removed it also not too long ago--together with VOP_LEASE). Jeff doesn't say why he wants to remove it but it might be best removed only to return when there's a real consumer of the api. Sam