From owner-freebsd-current@FreeBSD.ORG Sun Feb 1 18:21:24 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FFC01065672 for ; Sun, 1 Feb 2009 18:21:24 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.freebsd.org (Postfix) with ESMTP id F381E8FC23 for ; Sun, 1 Feb 2009 18:21:23 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-003-220.pools.arcor-ip.net [88.66.3.220]) by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis) id 0ML29c-1LTgwc3JUX-0001tt; Sun, 01 Feb 2009 19:21:22 +0100 Received: (qmail 57260 invoked from network); 1 Feb 2009 18:21:22 -0000 Received: from fbsd8.laiers.local (192.168.4.200) by ns1.laiers.local with SMTP; 1 Feb 2009 18:21:22 -0000 From: Max Laier Organization: FreeBSD To: freebsd-current@freebsd.org, barney_cordoba@yahoo.com Date: Sun, 1 Feb 2009 19:21:22 +0100 User-Agent: KMail/1.10.4 (FreeBSD/8.0-CURRENT; KDE/4.1.4; i386; ; ) References: <16190.90052.qm@web63904.mail.re1.yahoo.com> In-Reply-To: <16190.90052.qm@web63904.mail.re1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902011921.22305.max@love2party.net> X-Provags-ID: V01U2FsdGVkX1+2efBydvYPjkUEL1cJLoJRM3nW2hTDQsPIPXB Vf6HuHXqugD1AbeB5VpPVNOoafoPPmn3ZHomiBH87RDty33JuL zXkBo+vcUUY9JjX7YVkug== Cc: Subject: Re: Possible bug in ip_input() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2009 18:21:25 -0000 On Sunday 01 February 2009 17:07:51 Barney Cordoba wrote: > I've noticed the following possible inconsistency. > > 1) ip_input() is called with M_FASTFWD_OUR set > 2) ip_off is not "adjusted" to host representation That's because ip_off should already be in host byte order at that point. M_FASTFWD_OUR indicates that the packet is relooped from within the ip processing path which uses host byte order for ip_off and ip_len throughout. > 3) ip reassembly is erroneously called. > > I don't have an actual case that can test this, but it seems like an issue. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News