From owner-freebsd-net@FreeBSD.ORG Wed Feb 11 08:54:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49FD7BE9 for ; Wed, 11 Feb 2015 08:54:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 27AB1E91 for ; Wed, 11 Feb 2015 08:54:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1B8swa9074930 for ; Wed, 11 Feb 2015 08:54:58 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1B8sw9W074929; Wed, 11 Feb 2015 08:54:58 GMT (envelope-from root) Date: Wed, 11 Feb 2015 08:54:58 +0000 To: freebsd-net@freebsd.org From: "davide (Davide Italiano)" Subject: [Differential] [Commented On] D1809: [sockbuf] Don't expose lock details when isn't needed Message-ID: <2985078bfa16e89f498437d6492a2d65@localhost.localdomain> X-Priority: 3 Thread-Topic: D1809: [sockbuf] Don't expose lock details when isn't needed X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZDUyNzQ5ZWQxMTRmZDFiNGM0NTM4Yzk5MDEwIFTbGOI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 08:54:59 -0000 davide added a comment. Robert, an added (somewhat related) note. SCTP has already its own sockbuf(s) and this makes integration very hackish in the tree. IIRC glebius experienced this himself while working on sendfile(), and I'm pretty sure rrs@ is kind of familiar with the problem. Introducing a better abstraction for sockbuf might help with this. REVISION DETAIL https://reviews.freebsd.org/D1809 To: davide, kmacy, np, rrs, lstewart, rwatson Cc: julian, freebsd-net