From owner-svn-src-all@freebsd.org Wed Jun 6 05:35:01 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7354EFE2606; Wed, 6 Jun 2018 05:35:01 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CAEC084A0C; Wed, 6 Jun 2018 05:35:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id QR5vfkucWuYopQR5xfSHfZ; Tue, 05 Jun 2018 23:34:54 -0600 X-Authority-Analysis: v=2.3 cv=GopsBH9C c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=7mUfYlMuFuIA:10 a=xfDLHkLGAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=r5dZ4yu8JJ6XAt6c_8cA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 712CB1B43; Tue, 5 Jun 2018 22:34:51 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w565XiNG048883; Tue, 5 Jun 2018 22:33:44 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w565XiAI048880; Tue, 5 Jun 2018 22:33:44 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201806060533.w565XiAI048880@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Matthew Macy cc: Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334701 - in head: lib/libpmc share/examples/hwpmc sys/dev/hwpmc sys/sys usr.sbin/pmc usr.sbin/pmcstat In-Reply-To: Message from Matthew Macy of "Tue, 05 Jun 2018 22:28:22 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 05 Jun 2018 22:33:44 -0700 X-CMAE-Envelope: MS4wfAcuTkJjjtp4Fw7gQ659jhHEku328xzvInDfN+48LhZy8fEd2B8UTFzWvsXAiBHfjid97ooeRZQHd+FnggRfY7nlc7231IGkq1MqDacmOOUXtzfykxRs OXIoT43OC1t91M0r/OJYa1ShICPO1yYPk95BIWZa4NciP7MhQXYbCjYLmhzMmAytZ26uH+miqJdOrBAThLXiNfi9oDCrydRYBkYePlzT12ftXmhcf6RCmt9w +Vm101/mrx87U1tfquM6hKsHtj6rx0mu4ock6e1Ux982XpS1s2Dj4TnOKeoSduQd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 05:35:01 -0000 I came to that same conclusion myself moments ago. Thanks. In message , Matthew Macy writes: > -DNO_CLEAN doesn't work with the file rename. > > On Tue, Jun 5, 2018 at 10:14 PM, Cy Schubert wrot > e: > > amd64 > > > > ~cy > > > > In message > il.com> > > , Matthew Macy writes: > >> Which arch? Universe is passing for me (except for pre-existing > >> breakage of i386-LINT-NOINET). > >> > >> -M > >> > >> On Tue, Jun 5, 2018 at 8:53 PM, Cy Schubert wr > ote > >> : > >> > In message <201806060248.w562m9tB083134@repo.freebsd.org>, Matt Macy > >> > writes: > >> >> Author: mmacy > >> >> Date: Wed Jun 6 02:48:09 2018 > >> >> New Revision: 334701 > >> >> URL: https://svnweb.freebsd.org/changeset/base/334701 > >> >> > >> >> Log: > >> >> hwpmc: add summary command and further metadata extensions > >> >> > >> >> metadata changes: > >> >> - log pmc sample rate with pmcallocate > >> >> - log proc flags with thread / process logging > >> >> to identify user vs kernel threads > >> >> > >> >> fixes: > >> >> - use log cpuid to translate event id to event name > >> >> > >> >> Implement rudimentary summary command to track sample > >> >> counts by thread and process name within a pmc log. > >> >> > >> >> % make -j4 buildkernel >& /dev/null & > >> >> % sudo pmcstat -S unhalted_core_cycles -S llc-misses -O foo sleep 15 > >> >> % pmc summary foo > >> >> cpu_clk_unhalted.thread_p_any: > >> >> idle: 138108207162 > >> >> clang-6.0: 105336158004 > >> >> sh: 72340108510 > >> >> make: 8642012963 > >> >> kernel: 7754011631 > >> >> longest_lat_cache.miss: > >> >> clang-6.0: 87502625 > >> >> sh: 40901227 > >> >> make: 5500165 > >> >> kernel: 3300099 > >> >> awk: 2000060 > >> >> > >> >> % pmc summary -f ~/foo > >> >> idx: 278 name: cpu_clk_unhalted.thread_p_any rate: 2000003 > >> >> idle: 69054 > >> >> clang-6.0: 52668 > >> >> sh: 36170 > >> >> make: 4321 > >> >> kernel: 3877 > >> >> hwpmc: proc(7445): 3319 > >> >> awk: 1289 > >> >> xargs: 357 > >> >> rand_harvestq: 181 > >> >> mtree: 102 > >> >> intr: 53 > >> >> zfskern: 31 > >> >> usb: 7 > >> >> pagedaemon: 4 > >> >> ntpd: 3 > >> >> syslogd: 1 > >> >> acpi_thermal: 1 > >> >> logger: 1 > >> >> syncer: 1 > >> >> snmptrapd: 1 > >> >> sleep: 1 > >> >> idx: 17 name: longest_lat_cache.miss rate: 100003 > >> >> clang-6.0: 875 > >> >> sh: 409 > >> >> make: 55 > >> >> kernel: 33 > >> >> awk: 20 > >> >> hwpmc: proc(7445): 14 > >> >> xargs: 9 > >> >> idle: 8 > >> >> intr: 3 > >> >> zfskern: 2 > >> > > >> > Hi Matt, > >> > > >> > I'm not sure if this is due to this commit or one of your others but > >> > it's broken the build. > >> > > >> > Sorry I can't do any more analysis but I need to get dinner on the > >> > table. > >> > > >> > > >> > > >> > > >> > -- > >> > Cheers, > >> > Cy Schubert > >> > FreeBSD UNIX: Web: http://www.FreeBSD.org > >> > > >> > The need of the many outweighs the greed of the few. > >> > > >> > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: http://www.FreeBSD.org > > > > The need of the many outweighs the greed of the few. > > > > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.