From owner-dev-commits-src-main@freebsd.org Fri Mar 5 19:44:54 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9E73565096; Fri, 5 Mar 2021 19:44:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DsdVZ5JV1z3Npb; Fri, 5 Mar 2021 19:44:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x830.google.com with SMTP id j3so2646354qtj.12; Fri, 05 Mar 2021 11:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y5Qh5X1jPC/kugc3S4uHPl1RjwJ1IDnQBzN6/aJOSRc=; b=RVEwkchKZ2LU5WcAodsdptqN5udkPxoO0o8CxlvcAg6NizfLku9rFvAy5Pj2Y6/BxE zLQo0EOTsngTufag1FTHqN+fjoAFDBakcWC3P4ONQbP3X79JE5MtBBO9ULJVsNiiDlY3 WFOlG1uNMHPmS1nTl7Z4worRWqz6uBu2jrzwXehrGEmS3+ShhXXZ6ktIPjmcieh4YjIE LhZYG6KFsjMsqF+jIAcrvcUNVJXxVBh/8Ise8imzCKk0DCA6ubR2C5NUgkeHJn8PYxsp vfU6xqYZnuDjgt0HJWErYiihBF8QnqrahBYJpxOTwA4rHEE1rIKvXLFtGcVgiv8q7wPU ww2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=y5Qh5X1jPC/kugc3S4uHPl1RjwJ1IDnQBzN6/aJOSRc=; b=tiivttiDMZ1qhme/FkDEbeXXQnrX7ZAn4pX3oBwAwNCp46RFuzd2+EP2TWCGNSoZac MO9+kwVB7ZVYqNMYncBCp5M21hwLgYHR3j2kl2GRCrH/tBEHV5eV484WszKiZf0pcbf4 Eo7hpUwE/IYOI7HgPFh4005idTZLqCZZBcc9gMfZPBoM6kSDbF8FploSWAbmTnjEEAX1 afVHIOIoxB5GGQimz5RDNmEw3CzvvTlBf5r4Hz8mP/muARJt16N0u7KJaZkuGkFfaGft VRp+bkIvA30spaqt+Qb49jH6c9FgVaUjp74zuDruWPrFHM2howE02igvkWNXyQEwZY7V IPLw== X-Gm-Message-State: AOAM530NS9/TJ74r9TPPJLDpa5yp5ZfMydC+IePZFfvHj/A7zIhB7CaC XUYgNHRqoTswKudMmiKCAoYnMWXGQDR/4Q== X-Google-Smtp-Source: ABdhPJyoE5WnyWbKuQP8HL3g/VtT1UnvVpIvMxNHHjFfeaIaLAsBbSRlERWAAOlXsWTDcSszx/gEzQ== X-Received: by 2002:ac8:5892:: with SMTP id t18mr10967828qta.76.1614973487817; Fri, 05 Mar 2021 11:44:47 -0800 (PST) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id v187sm2496826qkd.50.2021.03.05.11.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 11:44:47 -0800 (PST) Sender: Mark Johnston Date: Fri, 5 Mar 2021 14:44:50 -0500 From: Mark Johnston To: Ryan Moeller Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c4ba4aa54718 - main - libifconfig: Overhaul ifconfig_media_* interfaces Message-ID: References: <202103051123.125BNubR059014@gitrepo.freebsd.org> <20c6efb4-8b57-ae78-3808-b49b07ac284d@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20c6efb4-8b57-ae78-3808-b49b07ac284d@FreeBSD.org> X-Rspamd-Queue-Id: 4DsdVZ5JV1z3Npb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 19:44:55 -0000 On Fri, Mar 05, 2021 at 02:40:29PM -0500, Ryan Moeller wrote: > > On 3/5/21 1:19 PM, Konstantin Belousov wrote: > > On Fri, Mar 05, 2021 at 11:23:56AM +0000, Ryan Moeller wrote: > >> The branch main has been updated by freqlabs: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=c4ba4aa547184ab401204096cdad9def4ab37964 > >> > >> commit c4ba4aa547184ab401204096cdad9def4ab37964 > >> Author: Ryan Moeller > >> AuthorDate: 2021-03-02 10:29:17 +0000 > >> Commit: Ryan Moeller > >> CommitDate: 2021-03-05 09:15:55 +0000 > >> > >> libifconfig: Overhaul ifconfig_media_* interfaces > >> > >> Define an ifmedia_t type to use for ifmedia words. > >> > >> Add ifconfig_media_lookup_* functions to lookup ifmedia words by name. > >> > >> Get media options as an array of option names rather than formatting it > >> as a comma-delimited list into a buffer. > >> > >> Sprinkle const on static the static description tables for peace of > >> mind. > >> > >> Don't need to zero memory allocated by calloc. > >> > >> Reviewed by: kp > >> MFC after: 2 weeks > >> Differential Revision: https://reviews.freebsd.org/D29029 > >> --- > >> lib/libifconfig/Makefile | 2 +- > >> lib/libifconfig/Symbol.map | 9 +- > >> lib/libifconfig/libifconfig.h | 69 +++++++- > >> lib/libifconfig/libifconfig_media.c | 339 ++++++++++++++++++++++++------------ > >> share/examples/libifconfig/status.c | 27 ++- > >> 5 files changed, 324 insertions(+), 122 deletions(-) > >> > >> diff --git a/lib/libifconfig/Makefile b/lib/libifconfig/Makefile > >> index 73dad36c1dc5..c6f006018427 100644 > >> --- a/lib/libifconfig/Makefile > >> +++ b/lib/libifconfig/Makefile > >> @@ -7,7 +7,7 @@ INTERNALLIB= true > >> LIBADD= m > >> > >> SHLIBDIR?= /lib > >> -SHLIB_MAJOR= 1 > >> +SHLIB_MAJOR= 2 > >> > >> VERSION_DEF= ${LIBCSRCDIR}/Versions.def > >> SYMBOL_MAPS= ${.CURDIR}/Symbol.map > > libifconfig is marked as internal, but we provide symbol versioning for it, > > and do it in the normal FreeBSD namespace. On one hand, our policy is to > > not bump symvered libs and to provide binary compat shims as needed, on the > > other, this is internal lib. > > > > What is the purpose of maintaining symbol versions for it? > > > I have work in progress that changes libifconfig to a private lib. I'm > not sure why markj@ added the symbol map, but I've been forced to > maintain it for my later changes to work. I added it because there was some discussion of making it a public library, and adding a symbol map was a step towards that. If it is only going to be a private library, then there's indeed no reason to maintain it.