Date: Tue, 20 Sep 2016 10:01:47 +0000 From: =?UTF-8?Q?Otac=C3=ADlio_de_Ara=C3=BAjo_Ramos_Neto?= <otacilio.neto@bsd.com.br> To: Matthieu Volat <mazhe@alkumuna.eu>, freebsd-ports@freebsd.org Subject: Re: Patch to cmake detect OpenMP Message-ID: <CAFt_gkyXNAw5XFcax57SVNtxOunWBXANgV3XVZ-O6UDqAQ2_gQ@mail.gmail.com> In-Reply-To: <20160920090405.221a4611@freedom.alkumuna.eu> References: <029185d0-d810-247d-d0c5-cdd8bc4a53ac@bsd.com.br> <20160920090405.221a4611@freedom.alkumuna.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
Em ter, 20 de set de 2016 04:04, Matthieu Volat <mazhe@alkumuna.eu> escreveu: > On Tue, 20 Sep 2016 00:55:44 -0300 > Otac=C3=ADlio <otacilio.neto@bsd.com.br> wrote: > > > I'm trying to port flann (http://www.cs.ubc.ca/research/flann/) to > > FreeBSD, but I need that cmake detects OpenMP. Unhappy, cmake do not > > detects OpenMP even when devel/openmp is installed, so I did this patc= h > > to cmake port. What you guys think about? Can I open a bug report with > > patch? > > > > []'s > > > > Hi, are you planning to submit this patch for cmake in ports or the > upstream project? > > This is not a really good idea to hardcode /usr/local like that, for ther= e > can be may more providers for libomp (lang/clangXY ports, if you need a > specific to workaround bugs for example... or even maybe base in the > future?). Also, it would break cmake with GCC. > > Without changing any upstream code in either cmake or flann, for FreeBSD > 11+, you can just set : > > USES+=3D compiler:openmp > CFLAGS+=3D -I${LOCALBASE}/include > LDFLAGS+=3D -L${LOCALBASE}/lib -lomp -lm > > I did not test how this behave on older release yet... And if you need to > build cmake-based projects outside ports, here's the flags I use: > > -DCMAKE_REQUIRED_INCLUDES=3D"/usr/local/include" \ > -DCMAKE_REQUIRED_LIBRARIES=3D"-L/usr/local/lib -lomp -lm" \ > -DCMAKE_EXE_LINKER_FLAGS=3D"-L/usr/local/lib -lomp -lm" \ > -DCMAKE_MODULE_LINKER_FLAGS=3D"-L/usr/local/lib -lomp -lm" \ > -DCMAKE_SHARED_LINKER_FLAGS=3D"-L/usr/local/lib -lomp -lm" > > -- Matthieu Volat <mazhe@alkumuna.eu> > Hi Matthieu. I was planning to submit this patch in ports but, after yours appointments, I have declined from the idea. My motivation was that if cmake proposes find OpenMP it must find OpenMP. But, my patch is not the right procedure to do it. []'s -Otacilio >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFt_gkyXNAw5XFcax57SVNtxOunWBXANgV3XVZ-O6UDqAQ2_gQ>