From owner-freebsd-stable@FreeBSD.ORG Mon Oct 22 16:08:18 2012 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0B1E8D32 for ; Mon, 22 Oct 2012 16:08:18 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 791708FC12 for ; Mon, 22 Oct 2012 16:08:17 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so1103250bkc.13 for ; Mon, 22 Oct 2012 09:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:disposition-notification-to:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:openpgp :content-type:content-transfer-encoding:x-gm-message-state; bh=VGfYlTy2kXWn1e1MvOHHAXaw037XHRh9JW0mQC6oM4o=; b=hQkE7mao4G8uyJaqQxtcdvI5qNvanSgVBwSnzm91P7xMByljBBZ0wUBm+9Ufql3fut 7GcuH5GerX/6wdgwILEtXRax6937Q2XkTvcIHe6zU4AS+8CSnb8IUoSksXfTQIBCajnq MP4R3GpHKgjdbEY6imDxxYfQALGidK9NGYBJWtOuzHrMi9y0wmvvKbtkGpPgMRlNj12Y jN3F/urPNVa2+ZmmI80Ij4vnFbIPNGkWrVpOmcs9ca6NYvBiEhE91dYT1nkVA3czXr8w wX5afjOutQ685047tdfRJIbIPBFNTB/4c39EdPJmPGPzhrdjrqoKNn1GTlaNBQUJwzRe 2iiw== Received: by 10.204.130.73 with SMTP id r9mr756029bks.131.1350922096147; Mon, 22 Oct 2012 09:08:16 -0700 (PDT) Received: from [192.168.1.2] ([89.169.140.97]) by mx.google.com with ESMTPS id v14sm4097541bkv.10.2012.10.22.09.08.15 (version=SSLv3 cipher=OTHER); Mon, 22 Oct 2012 09:08:15 -0700 (PDT) Message-ID: <50856F6F.40204@freebsd.org> Date: Mon, 22 Oct 2012 20:08:15 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: John Baldwin Subject: Re: ${CTFCONVERT_CMD} expands to empty string References: <5081F92F.8040004@freebsd.org> <508317A4.2060800@freebsd.org> <5084927C.1070101@freebsd.org> <201210221142.06889.jhb@freebsd.org> In-Reply-To: <201210221142.06889.jhb@freebsd.org> OpenPGP: id=964474DD Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQkzV0Q4xYursW6o62K1/Y3S2R/4r/Hn+i4vC8VoNdrvGKKfUeeqkhAqZ+mvDwtKLEmJsnTF Cc: stable@freebsd.org, freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 16:08:18 -0000 On 22.10.2012 19:42, John Baldwin wrote: > On Sunday, October 21, 2012 8:25:32 pm Andrey Chernov wrote: >> Those lines cause this error: >> .if ${MK_CTF} != "no" >> CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} >> .elif ${MAKE_VERSION} >= 5201111300 >> CTFCONVERT_CMD= >> .else >> CTFCONVERT_CMD= @: >> .endif >> >> My make version is 9201206140 >> So, either the check for >= 5201111300 is incorrect or change for empty >> make variables expansion is not merged into stable-9 > > I can't reproduce this doing a buildworld of a stable/9 checkout on a 9.0- > stable machine btw. What exact contents of /etc/src.conf and commands are you > using to reproduce this? > > I also can't find the string "empty string" in the output of my stable/9 > 'make universe' build before I committed this. > /etc/src.conf: WITHOUT_AMD=yes WITHOUT_APM=yes WITHOUT_ATM=yes WITHOUT_AUDIT=yes WITH_BSD_GREP=yes WITHOUT_BLUETOOTH=yes WITHOUT_BSNMP=yes WITHOUT_CDDL=yes WITHOUT_CLANG=yes WITHOUT_CTM=yes WITHOUT_FORTRAN=yes WITHOUT_GPIB=yes WITHOUT_GPIO=yes WITHOUT_GSSAPI=yes WITHOUT_I4B=yes WITH_IDEA=yes WITHOUT_IPFILTER=yes WITHOUT_IPX=yes WITHOUT_NCP=yes WITHOUT_NIS=yes WITHOUT_KERBEROS=yes WITHOUT_MAILWRAPPER=yes WITHOUT_PF=yes WITHOUT_PMC=yes WITHOUT_PROFILE=yes WITHOUT_RCMDS=yes WITHOUT_SLIP=yes WITHOUT_WIRELESS=yes I got that useless line _each_ .c file compiles. Example commands: cd /usr/src/usr.bin/make make clean make I got: cc -O2 -pipe -march=pentium4 -I/usr/src/usr.bin/make -DMAKE_VERSION=\"9201206140\" -DDEFSHELLNAME=\"sh\" -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/usr.bin/make/arch.c ${CTFCONVERT_CMD} expands to empty string ...etc... on each file.