From owner-freebsd-java@FreeBSD.ORG Thu Oct 7 13:50:49 2004 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 426FD16A5F2 for ; Thu, 7 Oct 2004 13:50:49 +0000 (GMT) Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr [139.124.41.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D66143D39 for ; Thu, 7 Oct 2004 13:50:48 +0000 (GMT) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: from arabica.esil.univ-mrs.fr (localhost.esil.univ-mrs.fr [127.0.0.1])i97DolHJ000774; Thu, 7 Oct 2004 15:50:47 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: (from rv@localhost) by arabica.esil.univ-mrs.fr (8.13.1/8.12.10/Submit) id i97Dok3p000773; Thu, 7 Oct 2004 15:50:46 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to herve.quiroz@esil.univ-mrs.fr using -f Date: Thu, 7 Oct 2004 15:50:46 +0200 From: Herve Quiroz To: Jeremy Faulkner Message-ID: <20041007135046.GA99606@arabica.esil.univ-mrs.fr> Mail-Followup-To: Jeremy Faulkner , java@freebsd.org References: <1097094403.90638.7.camel@ocean-deep.gldis.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1097094403.90638.7.camel@ocean-deep.gldis.ca> User-Agent: Mutt/1.4.2.1i cc: java@freebsd.org Subject: Re: Azureus port skeleton for testing X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2004 13:50:49 -0000 Jeremy, I am glad to see someone finally made a port for this tool. That would indeed be a good addition to the ports collection. I will test your port when I get some free time (I need to install eclipse as well). However, I a few comments by just looking at the files. First, the Makefile itself: - A quick portlint give me the following output: WARN: Makefile: "EXTRACT_ONLY" has to appear earlier. WARN: Makefile: "DISTFILES" has to appear earlier. WARN: Makefile: "EXTRACT_ONLY" has to appear earlier. 0 fatal errors and 3 warnings found. - It is generally not a good idea to install JAR files in ${PREFIX}/bin. As suggested in [1], a Java application should install its data files (such as its JAR files) in an overriden ${DATADIR} which is set to ${JAVASHAREDIR}/${PORTNAME}. - Not mandatory: if you install the JAR file in ${DATADIR} and wish to remove the entire pkg-plist file, just add the following line in Makefile: PLIST_FILES= bin/Azureus %%DATADIR%%/Azureus2.jar - The right way to install a script shell is by using ${INSTALL_SCRIPT}. To install a JAR file OTOH, I would suggest ${INSTALL_DATA} rather than just ${CP} to let the port install the file with correct owner, group and modes. - "Date created: October 6, 2003" <- I think you mean 2004 ;) - I don't have any pointer to justify my point but I am pretty sure porters are encouraged to name their ports using lowercase characters. I could be wrong so please anyone tell me if this is not the case. Second, looking at your shell script in files/, there are some things you may improve: - Too many paths are hardcoded. You may use %%PREFIX%% for instance and perform some sed magic in 'do-configure' target. Don't forget to differenciate ${PREFIX} (for everything related to the current port) and ${LOCALBASE} (for everything else, such as Eclipse stuff). - The same goes for the path of the 'java' executable. You could rather use the same kind of sed magic to replace %%JAVA%% with ${JAVA}. That said, this is just a quick review as I don't have enough time ATM. If nobody else handles this port by the next days, I will probably handle this myself. In such a case, you may send a PR and CC me. We're still under ports CVS tree freeze ATM, so there's no hurry here. Herve [1] Porter's Handbook - Using Java - Best practices http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html#JAVA-BEST-PRACTICES On Wed, Oct 06, 2004 at 08:27:07PM +0000, Jeremy Faulkner wrote: > This is just a first cut to test the functionality of the port. The > start-up script "Azureus" still has hardcoded variables that need to be > sorted out. I am also aware that some graphics do not display properly > in GUI, namely the "torrent health" and completion status bars (file and > pieces tabs). > > This port requires the Eclipse port because of eclipse's SWT libraries, > and will continue to do so until a separate port can be created for the > SWT libraries needed by both Eclipse and Azureus (and any other Java > application that uses SWT). > > http://www.gldis.ca/gldisater/Azureus.tar.gz > -- > Jeremy Faulkner