From owner-svn-ports-all@freebsd.org Wed Mar 15 13:18:45 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B199D0CFD5; Wed, 15 Mar 2017 13:18:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C4D36B8; Wed, 15 Mar 2017 13:18:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 63BCB5D83; Wed, 15 Mar 2017 13:18:44 +0000 (UTC) Date: Wed, 15 Mar 2017 13:18:44 +0000 From: Alexey Dokuchaev To: Diane Bruce Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436241 - in head/comms: . multimon-ng multimon-ng/files Message-ID: <20170315131844.GB39784@FreeBSD.org> References: <201703151313.v2FDDA2i048896@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201703151313.v2FDDA2i048896@repo.freebsd.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 13:18:45 -0000 On Wed, Mar 15, 2017 at 01:13:10PM +0000, Diane Bruce wrote: > New Revision: 436241 > URL: https://svnweb.freebsd.org/changeset/ports/436241 > > Log: > multimon-ng a fork of multimon. > It decodes the following digital transmission modes: > ... > +PLIST_FILES+= bin/multimon-ng Why += here? > +.include > +.if ${PORT_OPTIONS:MX11} > +USE_XORG+= sm ice x11 xext > +.endif Why not use option helpers (esp. since you're already using them above)? ./danfe