From owner-freebsd-mobile  Fri Jan 21  0: 1: 8 2000
Delivered-To: freebsd-mobile@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP id 97F5815136
	for <mobile@FreeBSD.ORG>; Fri, 21 Jan 2000 00:01:05 -0800 (PST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id BAA82769;
	Fri, 21 Jan 2000 01:01:04 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id BAA09842; Fri, 21 Jan 2000 01:01:02 -0700 (MST)
Message-Id: <200001210801.BAA09842@harmony.village.org>
To: Tatsumi Hosokawa <hosokawa@itc.keio.ac.jp>
Subject: Re: if_sn now works on -current (Re: One more serious problem with -current PCCARD support ) 
Cc: mobile@FreeBSD.ORG
In-reply-to: Your message of "Fri, 21 Jan 2000 02:54:40 +0900."
		<863drs1vdr.wl@ringo.FromTo.Cc> 
References: <863drs1vdr.wl@ringo.FromTo.Cc>  <86r9fisfe2.wl@ringo.FromTo.Cc> <86u2kesizg.wl@ringo.FromTo.Cc> <200001180742.AAA15379@harmony.village.org> <864sc820u4.wl@ringo.FromTo.Cc> 
Date: Fri, 21 Jan 2000 01:01:02 -0700
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

In message <863drs1vdr.wl@ringo.FromTo.Cc> Tatsumi Hosokawa writes:
: card "Megahertz" "CC10BT/2"
:         config  0x1 "sn0" ?
:         ether attr2
:         insert  logger -s Megahertz X-Jack Ethernet inserted
:         insert  /etc/pccard_ether $device
:         remove  logger -s Megahertz X-Jack Ethernet removed
:         remove  /etc/pccard_ether_remove $device

Looks good.

: This patch adds "attr2" keyword to /etc/pccard.conf and I'm afraid
: that it can break feature freeze.  If it's not acceptable, I'll commit
: it later.

That is fine by me.  When you commit this, you may want to add that I
said it was OK.

: Index: sys/dev/sn/if_sn_pccard.c

I think you missed the kludge I have in if_sn.c:

	if (1) {
		/* XXX The pccard probe routine for megahearts needs to */
		/* XXX snag this from your info 2 */
		int j;

		for (j = 0; j < 3; j++) {
			u_short	w;

			w = (u_short)sn_pccard_macaddr[j * 2] | 
				(((u_short)sn_pccard_macaddr[j * 2 + 1]) << 8);
			outw(BASE + IAR_ADDR0_REG_W + j * 2, w);
		}
	}

which needs to be replaced by more appropriate code.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message