From owner-cvs-src@FreeBSD.ORG Wed Jan 2 20:59:50 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93F5816A473 for ; Wed, 2 Jan 2008 20:59:50 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 4791B13C4EC for ; Wed, 2 Jan 2008 20:59:50 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 89378 invoked from network); 2 Jan 2008 20:59:51 -0000 Received: from 209-128-117-003.bayarea.net (HELO ?10.0.8.5?) (nate-mail@209.128.117.3) by root.org with ESMTPA; 2 Jan 2008 20:59:51 -0000 Message-ID: <477BFB9D.8070201@root.org> Date: Wed, 02 Jan 2008 13:01:17 -0800 From: Nate Lawson User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Poul-Henning Kamp References: <20080102203119.BFF8616A55D@hub.freebsd.org> In-Reply-To: <20080102203119.BFF8616A55D@hub.freebsd.org> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@FreeBSD.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2008 20:59:50 -0000 Poul-Henning Kamp wrote: > phk 2008-01-02 20:31:14 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.h > Log: > Follow the current fashion of gratuitously stomping into other > peoples code with irrelevant changes[1]: > > Use bus_{read|write_*() instead of bus_space_{read|write}_*() for > purely stylistic reasons. > > Due to compiler optimizations and inlining, this is for all practical > purposes without effect in the compiled code. Ok, but this still doesn't address the performance loss fixed by this 3-year-old patch: http://lists.freebsd.org/pipermail/freebsd-current/2005-January/044858.html > Revision Changes Path > 1.127 +14 -36 src/sys/dev/ata/ata-all.h > > > Index: src/sys/dev/ata/ata-all.h > diff -u src/sys/dev/ata/ata-all.h:1.126 src/sys/dev/ata/ata-all.h:1.127 > --- src/sys/dev/ata/ata-all.h:1.126 Thu Dec 13 11:47:36 2007 > +++ src/sys/dev/ata/ata-all.h Wed Jan 2 20:31:14 2008 > @@ -579,56 +579,34 @@ > > /* macros to hide busspace uglyness */ > #define ATA_INB(res, offset) \ > - bus_space_read_1(rman_get_bustag((res)), \ > - rman_get_bushandle((res)), (offset)) > + bus_read_1((res), (offset)) -- Nate