From owner-cvs-all@FreeBSD.ORG Wed Apr 21 05:41:04 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE87016A4CE; Wed, 21 Apr 2004 05:41:04 -0700 (PDT) Received: from shaft.techsupport.co.uk (shaft.techsupport.co.uk [212.250.77.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CD5243D41; Wed, 21 Apr 2004 05:41:04 -0700 (PDT) (envelope-from setantae@submonkey.net) Received: from cpc2-cdif3-6-0-cust204.cdif.cable.ntl.com ([81.103.67.204] helo=shrike.submonkey.net ident=mailnull) by shaft.techsupport.co.uk with esmtp (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.31; FreeBSD) id 1BGH2F-000581-4g; Wed, 21 Apr 2004 13:41:03 +0100 Received: from setantae by shrike.submonkey.net with local (Exim 4.32; FreeBSD) id 1BGH2C-000IrJ-Pl; Wed, 21 Apr 2004 13:41:00 +0100 Date: Wed, 21 Apr 2004 13:41:00 +0100 From: Ceri Davies To: Eivind Eklund Message-ID: <20040421124100.GT32710@submonkey.net> Mail-Followup-To: Ceri Davies , Eivind Eklund , David O'Brien , Clement Laforet , Alexey Dokuchaev , ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-ports@FreeBSD.org References: <200404181922.i3IJMkTf044706@repoman.freebsd.org> <20040419032304.GA61048@regency.nsu.ru> <20040419103101.GB26102@dragon.nuxi.com> <20040419110810.GA24385@regency.nsu.ru> <20040420200903.GA6174@dragon.nuxi.com> <20040421094050.GA5052@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9pS2hy4/DrI8BQlq" Content-Disposition: inline In-Reply-To: <20040421094050.GA5052@FreeBSD.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.4i Sender: Ceri Davies cc: Alexey Dokuchaev cc: Clement Laforet cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org cc: David O'Brien cc: cvs-ports@FreeBSD.org Subject: Re: files/patch-* pathname separators (was Re: cvs commit: ports/games Makefile ...) X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2004 12:41:05 -0000 --9pS2hy4/DrI8BQlq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 21, 2004 at 09:40:50AM +0000, Eivind Eklund wrote: > On Tue, Apr 20, 2004 at 01:09:03PM -0700, David O'Brien wrote: > > On Mon, Apr 19, 2004 at 06:08:10PM +0700, Alexey Dokuchaev wrote: > > > While particular choice for a separator is arguable, the general sche= me > > > for patch-files is not, right? FWIW, that was my point, not `::' vs. > > > whatever. > > >=20 > > > As a side note, I don't really see any problem with `::' or `-'. > >=20 > > 1. Bash escapes it so it actually becomes 4 characters. > > This should not be takeing lightly -- people bitched about '%' in > > patch names and they were all changed because its a magic charter for > > Perforce and Perforce users could be bothered to escape it. > >=20 > > 2. With the file name lenths of some of our patches (greater than 80 > > chars) two characters, when one will do, is annoying. >=20 > If nobody objects, I'll add the following patch to the porters handbook > to avoid profileration. >=20 > Index: book.sgml > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml= ,v > retrieving revision 1.400 > diff -u -r1.400 book.sgml > --- book.sgml 16 Apr 2004 15:05:32 -0000 1.400 > +++ book.sgml 21 Apr 2004 09:38:25 -0000 > @@ -617,7 +617,10 @@ > first, ab second and so on. If you wish, > you can use names that indicate the pathnames of the files that > are patched, such as patch-Imakefile or > - patch-src-config.h. These files should > + patch-src-config.h. Due to issues with > + escaping in bash and Perforce, ^^^^^^^ ^^^^^^^ These should be marked up with Ceri --=20 --9pS2hy4/DrI8BQlq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAhmvcocfcwTS3JF8RAuCtAJ4mkYPfdEiY5xry5K1THWVnxthfWQCbB3ez w1L7b7AUQsVW9bpjYXYysyg= =enhi -----END PGP SIGNATURE----- --9pS2hy4/DrI8BQlq--