From owner-p4-projects@FreeBSD.ORG  Wed Jan  3 12:48:52 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4C92916A47E; Wed,  3 Jan 2007 12:48:52 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E003416A415;
	Wed,  3 Jan 2007 12:48:51 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 71B1513C478;
	Wed,  3 Jan 2007 12:48:51 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id l03CWuXj078249
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 3 Jan 2007 13:32:56 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id l03CWukS078247;
	Wed, 3 Jan 2007 13:32:56 +0100 (CET)
Date: Wed, 3 Jan 2007 13:32:56 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20070103123256.GA76983@stud.fit.vutbr.cz>
References: <200612312353.kBVNrYYY007010@repoman.freebsd.org>
	<200701021129.54537.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200701021129.54537.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: Roman Divacky <rdivacky@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112379 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2007 12:48:52 -0000

On Tue, Jan 02, 2007 at 11:29:54AM -0500, John Baldwin wrote:
> On Sunday 31 December 2006 18:53, Roman Divacky wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=112379
> > 
> > Change 112379 by rdivacky@rdivacky_witten on 2006/12/31 23:53:30
> > 
> > 	Implement SETALL/GETALL IPC primitives. This fixes some LTP testcases.
> 
> Are you sure it's actually working?  I thought Linux semid structure was a
> different size, and GETALL and SETALL try to copyin and copyout data from
> userland without doing any conversions.

I only tested with the LTP tests and it fixed all cases there. 

the [SG]ETALL copies in/out u_char * nsems which looks quite OS independant.

someone reported that some program doesnt work because of missing SETALL/GETALL
I think that if the one reportes that this patch fixes it we can consider it ok.
(because we have 2 positive reports and 0 negative)

opinion?