From owner-freebsd-current@freebsd.org Sun Nov 15 03:28:27 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7C1DA2E74A; Sun, 15 Nov 2015 03:28:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x235.google.com (mail-pa0-x235.google.com [IPv6:2607:f8b0:400e:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D84A1924; Sun, 15 Nov 2015 03:28:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacdm15 with SMTP id dm15so138820507pac.3; Sat, 14 Nov 2015 19:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8UqeDDblaqNey5H3L6WPtcotAJXVLo5UzTQQ4xBHo2A=; b=JHUjuFyjd24wiMfRi3AaJ3wHSCbR5gg1Bs3iZs9EXxsmQWerHMtiVwunFwz4p6KxXe LOFXeLn1cuzoTkX8er+bwiIn+ztzjEEPqwxUrMCgiaT/DwpoFWAs86XWSnKrZAMpd8Y4 eArKQ0wKd8SZSrS8iG4UHMEFbMNeICRvYMUELpcVSfiCZLiTHHl7OEKNqxiWfewu1oOV N/BlpaCSRioKr0oR9l5CD2Db1CkogehVsF4xYhPYVdns4HwyrGxNZikPjam/Vnei29M5 l7eIkfAedhYQxtseMWZOSHYL3TLOFqCqppQiMoZiJ3LCoNkWRE7ajvQUT2JnguvOF7Ju m52A== X-Received: by 10.66.229.2 with SMTP id sm2mr44079496pac.28.1447558107167; Sat, 14 Nov 2015 19:28:27 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:1591:4178:5777:4e52? ([2601:601:800:126d:1591:4178:5777:4e52]) by smtp.gmail.com with ESMTPSA id n6sm14333355pap.24.2015.11.14.19.28.24 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Nov 2015 19:28:25 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Need help fixing failing locale tests From: NGie Cooper In-Reply-To: Date: Sat, 14 Nov 2015 19:28:23 -0800 Cc: Baptiste Daroussin , John Marino , freebsd-current Current , "freebsd-testing@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <69242BD8-9010-47F0-9706-BE206376ECEA@gmail.com> References: To: Craig Rodrigues X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2015 03:28:27 -0000 > On Nov 14, 2015, at 19:18, Craig Rodrigues wrote: > > On Sat, Nov 14, 2015 at 7:05 PM, Craig Rodrigues > wrote: > >> Hi, >> >> After the recent locale commits, some of the tests are failing: >> >> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1675/testReport/ >> >> I can reproduce two failures quite easily by doing with a newly built >> world: >> >> /bin/sh /usr/tests/bin/sh/builtins/case7.0 >> /bin/sh /usr/tests/bin/sh/builtins/locale1.0 >> >> Can someone look into this and help fix this? >> >> I don't know much about locales, so don't know what to do. >> > > > I ran the two tests using bash, and got different error messages: > > /usr/local/bin/bash /usr/tests/bin/sh/builtins/case7.0 > /usr/tests/bin/sh/builtins/case7.0: line 7: warning: setlocale: LC_CTYPE: > cannot change locale (de_DE.ISO8859-1): Invalid argument > /usr/tests/bin/sh/builtins/case7.0: line 9: warning: setlocale: LC_COLLATE: > cannot change locale (de_DE.ISO8859-1): Invalid argument > wrong at 18 > wrong at 23 > > /usr/local/bin/bash /usr/tests/bin/sh/builtins/locale1.0 > /usr/tests/bin/sh/builtins/locale1.0: line 45: warning: setlocale: > LC_CTYPE: cannot change locale (nl_NL.ISO8859-1): Invalid argument > Failed: $ok -eq 1 at 56 > /usr/tests/bin/sh/builtins/locale1.0: line 64: warning: setlocale: LC_ALL: > cannot change locale (nl_NL.ISO8859-1): No such file or directory > Failed: $ok -eq 1 at 68 > Failed: $ok -eq 1 at 74 > /usr/tests/bin/sh/builtins/locale1.0: regel 82: waarschuwing: setlocale(): > LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file > or directory > Failed: $ok -eq 1 at 86 > Failed: $ok -eq 1 at 99 > /usr/tests/bin/sh/builtins/locale1.0: regel 107: waarschuwing: setlocale(): > LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file > or directory > Failed: $ok -eq 1 at 111 > /usr/tests/bin/sh/builtins/locale1.0: regel 114: waarschuwing: setlocale(): > LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file > or directory > Failed: $ok -eq 1 at 118 > /usr/tests/bin/sh/builtins/locale1.0: regel 122: waarschuwing: setlocale(): > LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file > or directory > /usr/tests/bin/sh/builtins/locale1.0: regel 128: waarschuwing: setlocale(): > LC_ALL: kan niet van taalregio veranderen (nl_NL.ISO8859-1): No such file > or directory > Failed: $ok -eq 1 at 132 > > > On my system, I did: > ls -l /usr/share/locale/de_DE.ISO8859-1/* > -r--r--r-- 1 root wheel 4642 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_COLLATE > lrwxr-xr-x 1 root wheel 27 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_CTYPE -> ../la_LN.ISO8859-1/LC_CTYPE > -r--r--r-- 1 root wheel 18 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_MESSAGES > -r--r--r-- 1 root wheel 35 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_MONETARY > -r--r--r-- 1 root wheel 6 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_NUMERIC > -r--r--r-- 1 root wheel 367 Nov 6 12:53 > /usr/share/locale/de_DE.ISO8859-1/LC_TIME > > ls -l /usr/share/locale/nl_NL.ISO8859-1/* > lrwxr-xr-x 1 root wheel 29 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_COLLATE -> > ../la_LN.ISO8859-1/LC_COLLATE > lrwxr-xr-x 1 root wheel 27 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_CTYPE -> ../la_LN.ISO8859-1/LC_CTYPE > -r--r--r-- 1 root wheel 18 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_MESSAGES > -r--r--r-- 1 root wheel 35 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_MONETARY > -r--r--r-- 1 root wheel 6 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_NUMERIC > -r--r--r-- 1 root wheel 376 Nov 6 12:53 > /usr/share/locale/nl_NL.ISO8859-1/LC_TIME > > I saw that la_LN.ISO8859-1 does not exist, so the LC_CTYPE symlink is > pointing to nothing. Why were these locales removed? 58 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_COLLATE 59 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_CTYPE 60 OLD_FILES+=usr/share/locale/la_LN.ISO8859-1/LC_TIME 61 OLD_DIRS+=usr/share/locale/la_LN.ISO8859-1 62 OLD_FILES+=usr/share/locale/la_LN.ISO8859-13/LC_COLLATE 63 OLD_FILES+=usr/share/locale/la_LN.ISO8859-13/LC_CTYPE 64 OLD_DIRS+=usr/share/locale/la_LN.ISO8859-13