From owner-cvs-all@FreeBSD.ORG Tue Apr 21 16:27:23 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0D0D106566C; Tue, 21 Apr 2009 16:27:23 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from asuka.mahoroba.org (unknown [IPv6:2001:2f0:104:8010::1]) by mx1.freebsd.org (Postfix) with ESMTP id A04F28FC1E; Tue, 21 Apr 2009 16:27:23 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from yuga.mahoroba.org (yuga.mahoroba.org [IPv6:2001:2f0:104:8010:21b:d3ff:fe38:5381]) (user=ume mech=CRAM-MD5 bits=0) by asuka.mahoroba.org (8.14.3/8.14.3) with ESMTP/inet6 id n3LGR2O5068345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 Apr 2009 01:27:06 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Wed, 22 Apr 2009 01:27:02 +0900 Message-ID: From: Hajimu UMEMOTO To: Wesley Shields In-Reply-To: <200904211536.n3LFauSD031415@repoman.freebsd.org> References: <200904211536.n3LFauSD031415@repoman.freebsd.org> User-Agent: xcite1.58> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.3 (i386-portbld-freebsd7.2) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 7.2-RC1 X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Wed_Apr_22_01:27:01_2009-1" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (asuka.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Wed, 22 Apr 2009 01:27:07 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on asuka.mahoroba.org Cc: cvs-ports@FreeBSD.org, Daniel Roethlisberger , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/nmap Makefile ports/security/nmap/files patch-ncat__ncat_core.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 16:27:24 -0000 --Multipart_Wed_Apr_22_01:27:01_2009-1 Content-Type: text/plain; charset=US-ASCII Hi, >>>>> On Tue, 21 Apr 2009 15:36:56 +0000 (UTC) >>>>> Wesley Shields said: wxs> Modified files: wxs> security/nmap Makefile Z wxs> Added files: wxs> security/nmap/files patch-ncat__ncat_core.c wxs> Log: wxs> - Add patch to work around versions of FreeBSD with broken wxs> getaddrinfo(3) (7.1 and earlier, and -CURRENT before the end of March wxs> 2009). wxs> wxs> PR: ports/133779 wxs> Submitted by: Daniel Roethlisberger (maintainer) It seems this change is not good practice. The original usage of getadrinfo(3) is not good, in the first place. You can fix this by just adding ai_socktype hint. The replacement of patch-ncat__ncat_core.c is attached. Sorry, but I don't test it, actually. But, it should work. Please, try it. Sincerely, --Multipart_Wed_Apr_22_01:27:01_2009-1 Content-Type: text/x-patch; charset=US-ASCII Content-Disposition: attachment; filename="patch-ncat__ncat_core.c" Content-Transfer-Encoding: 7bit Index: ncat/ncat_core.c diff -u -p ncat/ncat_core.c.orig ncat/ncat_core.c --- ncat/ncat_core.c.orig 2009-04-02 11:57:42.000000000 +0900 +++ ncat/ncat_core.c 2009-04-22 00:58:48.839927966 +0900 @@ -89,6 +89,7 @@ int resolve(char *hostname, unsigned sho memset(&hints, 0, sizeof(hints)); hints.ai_family = o.af; + hints.ai_socktype = SOCK_DGRAM; if (o.nodns) hints.ai_flags |= AI_NUMERICHOST; --Multipart_Wed_Apr_22_01:27:01_2009-1 Content-Type: text/plain; charset=US-ASCII -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ --Multipart_Wed_Apr_22_01:27:01_2009-1--