From owner-p4-projects@FreeBSD.ORG  Fri Nov 14 13:20:49 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D08B616A4CE; Fri, 14 Nov 2003 13:20:48 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A880116A4CE
	for <perforce@freebsd.org>; Fri, 14 Nov 2003 13:20:48 -0800 (PST)
Received: from mail.speakeasy.net (mail5.speakeasy.net [216.254.0.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2695143FBF
	for <perforce@freebsd.org>; Fri, 14 Nov 2003 13:20:47 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 30422 invoked from network); 14 Nov 2003 21:20:46 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 14 Nov 2003 21:20:46 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id hAELKhEW008115;
	Fri, 14 Nov 2003 16:20:43 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20031114162040.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200311141846.hAEIkIap057379@repoman.freebsd.org>
Date: Fri, 14 Nov 2003 16:20:40 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 42350 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 21:20:49 -0000
X-List-Received-Date: Fri, 14 Nov 2003 21:20:49 -0000


On 14-Nov-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=42350
> 
> Change 42350 by peter@peter_overcee on 2003/11/14 10:46:16
> 
>       converge with -current a bit.  I dont know if jhb intends to commit this
>       change that I originally picked up via jhb_acpipci or not.

No, installnig atpic handlers by default is the better solution.

> Affected files ...
> 
> .. //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#9 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#9 (text+ko) ====
> 
> @@ -106,7 +106,6 @@
>       }
>       intrcnt_register(isrc);
>       interrupt_sources[vector] = isrc;
> -     isrc->is_pic->pic_enable_intr(isrc);
>       mtx_unlock_spin(&intr_table_lock);
>       return (0);
>  }
> @@ -132,6 +131,7 @@
>           ithread_priority(flags), flags, cookiep);
>       if (error == 0) {
>               intrcnt_updatename(isrc);
> +             isrc->is_pic->pic_enable_intr(isrc);
>               isrc->is_pic->pic_enable_source(isrc);
>       }
>       return (error);

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/