From owner-freebsd-fs@FreeBSD.ORG Wed Jul 24 12:29:03 2013 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id C9D142CE; Wed, 24 Jul 2013 12:29:03 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B25492D23; Wed, 24 Jul 2013 12:29:02 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA20838; Wed, 24 Jul 2013 15:29:01 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1V1yBg-0008Gv-Nz; Wed, 24 Jul 2013 15:29:00 +0300 Message-ID: <51EFC854.3090908@FreeBSD.org> Date: Wed, 24 Jul 2013 15:28:04 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130708 Thunderbird/17.0.7 MIME-Version: 1.0 To: John Baldwin Subject: Re: VOP_MKDIR/VOP_CREATE and namecache References: <51E968FC.20905@FreeBSD.org> <201307221110.32011.jhb@freebsd.org> In-Reply-To: <201307221110.32011.jhb@freebsd.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org, freebsd-arch@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2013 12:29:03 -0000 on 22/07/2013 18:10 John Baldwin said the following: > On Friday, July 19, 2013 12:27:40 pm Andriy Gapon wrote: >> >> Should VOP_MKDIR and VOP_CREATE immediately insert newly created vnodes into the >> namecache? If yes, where would it be done best? FS code, VFS code, VOP >> post-hooks, something else? > > Hmm, I'm not sure. However, if it is done, I think it needs to be done in the > FS code (e.g., NFS needs to be able to add it's special timestamps). > > In UFS you could do this by just adding a cache_enter() call to ufs_direnter(). > For NFS you would want the post-op attrs from the RPC reply (assuming it includes > attrs for the parent directory). > I've read this as "don't bother" :-) Thank you for the feedback! -- Andriy Gapon