Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Mar 2016 13:36:26 +0800
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        Jim Ohlstein <jim@ohlste.in>
Cc:        Kurt Jaeger <lists@opsec.eu>, Mathieu Arnold <mat@FreeBSD.org>, ports FreeBSD <freebsd-ports@FreeBSD.org>
Subject:   Re: Owncloud port marked broken with PHP 7.0 and MySQL
Message-ID:  <20160316053626.GA62787@ns.kevlo.org>
In-Reply-To: <56E7FC24.3050606@ohlste.in>
References:  <56E725AF.3000108@ohlste.in> <4BB1DBF1542C5E725325D045@atuin.in.mat.cc> <56E7F6E3.5020001@ohlste.in> <20160315115407.GV35640@home.opsec.eu> <56E7FC24.3050606@ohlste.in>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 15, 2016 at 08:12:20AM -0400, Jim Ohlstein wrote:
> 
> Hello,

Hi Jim,

> On 3/15/16 7:54 AM, Kurt Jaeger wrote:
> > Hi!
> >
> >> At the risk of sounding like a broken record (did you actually READ what
> >> I wrote?) Owncloud does NOT require php-mysql, it requires
> >> php-pdo_mysql. In PHP versions before 7.0 that pulled in the
> >> corresponding php-mysql port. It is NOT a requirement (there, I said it
> >> a THIRD time).
> >
> > Can you submit a patch to the ports (maybe fixing the depends) so that
> > it builds ?
> >
> 
> It's pretty straightforward. I'm guessing other ports were pulled in by 
> this blanket search for requiring mysql extension when in fact what was 
> needed was pdo-mysql.

You're right.  Owncloud doesn't require php-mysql, I committed your fix
as r411212, thanks.

> 
> --- Makefile	(revision 411153)
> +++ Makefile	(working copy)
> @@ -2,6 +2,7 @@
> 
>   PORTNAME=	owncloud
>   PORTVERSION=	9.0.0
> +PORTREVISION=	1
>   CATEGORIES=	www
>   MASTER_SITES=	http://download.owncloud.org/community/
> 
> @@ -40,8 +41,7 @@
>   LDAP_USE=	PHP=ldap
>   MP3INFO_BUILD_DEPENDS=	mp3info:${PORTSDIR}/audio/mp3info
>   MP3INFO_RUN_DEPENDS=	${MP3INFO_BUILD_DEPENDS}
> -MYSQL_USE=	MYSQL=client PHP=mysql,pdo_mysql
> -MYSQL_VARS=	IGNORE_WITH_PHP+=70
> +MYSQL_USE=	MYSQL=client PHP=pdo_mysql
>   PGSQL_USES=	pgsql
>   PGSQL_USE=	PHP=pdo_pgsql,pgsql
>   SQLITE_USE=	PHP=pdo_sqlite,sqlite3
> 
> 
> Build log available at http://bit.ly/1UdfsGA.
> 
> -- 
> Jim Ohlstein
> 
> 
> "Never argue with a fool, onlookers may not be able to tell the 
> difference." - Mark Twain
> 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160316053626.GA62787>