From nobody Mon Apr  3 16:03:54 2023
X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PqwgK0s0gz42wZd;
	Mon,  3 Apr 2023 16:03:57 +0000 (UTC)
	(envelope-from diizzy@FreeBSD.org)
Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4PqwgJ4Jffz4DXF;
	Mon,  3 Apr 2023 16:03:56 +0000 (UTC)
	(envelope-from diizzy@FreeBSD.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: (Authenticated sender: daniel.engberg@pyret.net)
	by mail.gandi.net (Postfix) with ESMTPA id 632FB240005;
	Mon,  3 Apr 2023 16:03:54 +0000 (UTC)
List-Id: Commit messages for all branches of the ports repository <dev-commits-ports-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all
List-Help: <mailto:dev-commits-ports-all+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-all@freebsd.org
X-BeenThere: dev-commits-ports-all@freebsd.org
MIME-Version: 1.0
Date: Mon, 03 Apr 2023 18:03:54 +0200
From: Daniel Engberg <diizzy@FreeBSD.org>
To: Gleb Popov <arrowd@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
 dev-commits-ports-main@freebsd.org
Subject: Re: git: 93eaa5412bfc - main - security/howdy: Face recognition based
 authentication provider.
In-Reply-To: <CALH631n8o8ncHU7tr986kDVDM8n27OBy2JPkbZrwtk6p+4ASxQ@mail.gmail.com>
References: <202304031415.333EFmQx016670@gitrepo.freebsd.org>
 <998481bfbf4a242146f9d783a5831e4b@FreeBSD.org>
 <CALH631n8o8ncHU7tr986kDVDM8n27OBy2JPkbZrwtk6p+4ASxQ@mail.gmail.com>
Message-ID: <ef8a5d9a85221904c70701b2d54e9d26@FreeBSD.org>
X-Sender: diizzy@FreeBSD.org
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 4PqwgJ4Jffz4DXF
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:29169, ipnet:2001:4b98::/32, country:FR]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On 2023-04-03 17:49, Gleb Popov wrote:
> On Mon, Apr 3, 2023 at 6:07 PM Daniel Engberg <diizzy@freebsd.org> 
> wrote:
>> 
>> Hi,
>> 
>> This seems to be incorrect versioning looking at
>> https://github.com/boltgolt/howdy/tags ?
>> Please follow Porters Handbook in such cases
>> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
>> 
>> Best regards,
>> Daniel
> 
> What exactly is incorrect? This port is for a beta version of the
> upcoming release.

The referenced commit doesn't define a version so either Example 16 or 
possibly Example 19 (some prefer the latter) should be used.

On top of that, PORTVERSION --> DISTVERSION and GH_TAGNAME should use a 
short hash

Best regards,
Daniel