Date: Tue, 29 Aug 1995 02:33:57 +1000 From: Bruce Evans <bde@zeta.org.au> To: CVS-commiters@freefall.FreeBSD.org, bde@freefall.FreeBSD.org, cvs-sys@freefall.FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_disksubr.c Message-ID: <199508281633.CAA06533@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: sys/ufs/ufs ufs_disksubr.c > Log: > Fix correct_writedisklabel() and writedisklabel(). Their setting of > bp->b_flags has been broken for many years: > a) they didn't set B_BUSY for doing i/o. This has been fatal since > 1995/07/25 when biodone() started checking that B_BUSY is set. > b) they didn't set B_INVAL for releasing the buffer. This at best > just put a useless buffer in the LRU queue for a little while. This should be in 2.1 since the fussy (buggy?) checking in biodone() is is already in 2.1. To test for the bug, change a label using `disklabel -e'. This should cause a panic in biodone() for all recent versions of vfs_bio.c. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508281633.CAA06533>