From owner-cvs-all Sat Mar 3 7:29:48 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 54CE737B721; Sat, 3 Mar 2001 07:29:41 -0800 (PST) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.11.3/8.11.3) id f23FTaU91209; Sat, 3 Mar 2001 18:29:36 +0300 (MSK) (envelope-from ache) Date: Sat, 3 Mar 2001 18:29:35 +0300 From: "Andrey A. Chernov" To: Jeroen Ruigrok/Asmodai Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/w w.c Message-ID: <20010303182934.B90930@nagual.pp.ru> References: <200103030132.f231WkD54292@freefall.freebsd.org> <20010303094632.A666@daemon.ninth-circle.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010303094632.A666@daemon.ninth-circle.org>; from asmodai@wxs.nl on Sat, Mar 03, 2001 at 09:46:32AM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, Mar 03, 2001 at 09:46:32 +0100, Jeroen Ruigrok/Asmodai wrote: > But the comma remains a logical seperator character for a lot of > countries. If it confuses the locale then either the print statement is > bogus or the locale has issues. A comma should just be able to be used. Standards NOT recommend using comma as float separator due to locale issues, f.e. see http://www.opengroup.org/onlinepubs/007908799/xbd/utilconv.html "Applications preparing for international use should be aware of an occasional problem with comma-separated lists: in some locales, the comma is used as the radix character. Thus, if an application is preparing operands for a utility that expects a comma-separated list, it should avoid generating non-integer values through one of the means that is influenced by setting the LC_NUMERIC variable" > Also, w is the same as uptime, so you also modified the header output of > uptime, which might break scripts, not sure though. They are breaked in anyway by another comma already comes from locale before latest change. > But then looking at your changes you don't fix anything! I fix separator - it is space now. Space is unlikely to be radix character. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message