Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Aug 2006 16:23:53 GMT
From:      Paolo Pisati <piso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 103178 for review
Message-ID:  <200608041623.k74GNrKD006200@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=103178

Change 103178 by piso@piso_newluxor on 2006/08/04 16:23:44

	Avoid deadlock: during taskqueue_free() some of the predefined
	tasks could be executed, so watch out not to do it
	while holding a lock that one of these tasks could 
	try to acquire.

Affected files ...

.. //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#7 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#7 (text+ko) ====

@@ -475,8 +475,8 @@
 		device_delete_child(dev, sc->bfe_miibus);
 
 	bfe_release_resources(sc);
+	BFE_UNLOCK(sc);
 	taskqueue_free(sc->sc_tq);
-	BFE_UNLOCK(sc);
 	mtx_destroy(&sc->bfe_mtx);
 
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608041623.k74GNrKD006200>