From owner-svn-ports-all@freebsd.org Tue Jan 24 16:38:24 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14A38CC084A; Tue, 24 Jan 2017 16:38:24 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D82E6813; Tue, 24 Jan 2017 16:38:23 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v0OGcMMX005804; Tue, 24 Jan 2017 16:38:22 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v0OGcMna005803; Tue, 24 Jan 2017 16:38:22 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201701241638.v0OGcMna005803@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Tue, 24 Jan 2017 16:38:22 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r432358 - head/astro/gpsbabel/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 16:38:24 -0000 Author: jbeich Date: Tue Jan 24 16:38:22 2017 New Revision: 432358 URL: https://svnweb.freebsd.org/changeset/ports/432358 Log: astro/gpsbabel: unbreak with clang 4.0 bushnell.cc:138:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ bushnell.cc:150:36: error: ordered comparison between pointer and zero ('const char *' and 'int') for (t = bushnell_icons; t->icon > 0; t++) { ~~~~~~~ ^ ~ PR: 216215 Submitted by: Oliver Heesakkers (maintainer) Added: head/astro/gpsbabel/files/patch-bushnell.cc (contents, props changed) Added: head/astro/gpsbabel/files/patch-bushnell.cc ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/astro/gpsbabel/files/patch-bushnell.cc Tue Jan 24 16:38:22 2017 (r432358) @@ -0,0 +1,22 @@ +https://github.com/gpsbabel/gpsbabel/issues/62 + +--- bushnell.cc.orig 2017-01-24 13:08:41 UTC ++++ bushnell.cc +@@ -135,7 +135,7 @@ bushnell_get_icon_from_name(QString name + name = "Waypoint"; + } + +- for (t = bushnell_icons; t->icon > 0; t++) { ++ for (t = bushnell_icons; t->icon != NULL; t++) { + if (0 == name.compare(t->icon, Qt::CaseInsensitive)) { + return t->symbol; + } +@@ -147,7 +147,7 @@ static const char* + bushnell_get_name_from_symbol(signed int s) + { + icon_mapping_t* t; +- for (t = bushnell_icons; t->icon > 0; t++) { ++ for (t = bushnell_icons; t->icon != NULL; t++) { + if (s == t->symbol) { + return t->icon; + }