Date: Mon, 23 Dec 2024 18:50:27 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 283343] that -D noise again in Mk/Uses/cran.mk Message-ID: <bug-283343-7788-kpZ4oRy6Vu@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-283343-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-283343-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283343 --- Comment #2 from Chad Jacob Milios <milios@ccsys.com> --- see /usr/ports/CHANGES @ 20240229 for details TLDR; nearly all uses of `${SETENV} ${MAKE_ENV} FOO=3Dbar ${GMAKE} ...` or `cd ${WRKSRC}/somewhere && do-a-thing` are being deprecated for rather `${SETEN= VI} ${WRK_ENV} ${MAKE_ENV} FOO=3Dbar ${GMAKE} ...` or `cd ${WRKSRC}/somewhere && ${SETENVI} ${WRK_ENV} do-a-thing`. (note the addition of the I to SETENVI and the explicit inclusion of WRK_EN= V) for the interested reader: bmake (our make) supports -D to set a make variable to 1. gmake (GNU make) stopped supporting it at some random point release a couple years ago. howe= ver, they both set/honor the MAKEFLAGS env var for passing and inferring particu= lar (all?) command line options. gmake subprocesses now bork out and spectacula= rly die in error with a non-useful message if the parent bmake was started with, for instance, -DBATCH instead of BATCH=3D1. tools like portmaster et al just punted, avoiding the use of -D "temporaril= y" until a time that shall probably never arrive. i still like to use -DFOO -D= BAR etc to set my booleans because it helps expose where we can improve isolati= on by cleaning our subprocess environments for building ports more consistently and securely. WRK_ENV can now be relied upon to carry that particular environment we inte= nd to explicitly pass down. see also ports commit 755d190db121778a25b45950c397163325d8e797, PRs #272216, #277492 and many others now containing SETENVI --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-283343-7788-kpZ4oRy6Vu>