From owner-svn-src-all@FreeBSD.ORG Fri Dec 3 21:56:36 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D15861065777; Fri, 3 Dec 2010 21:56:35 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 359EE8FC16; Fri, 3 Dec 2010 21:56:33 +0000 (UTC) Received: by wwf26 with SMTP id 26so5662900wwf.31 for ; Fri, 03 Dec 2010 13:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=KL8EobKjnqdsK7/Khrqe/twrrrfaRkjKGLby08hpX0w=; b=r03rQZFbgdMtk29e8qjLxq9HRk8p82+9GEnSdSpVwYZcHmLbcyox4dxRLhkUUlQZEV wuG8UufsZWdqJjQ2L1PL5vFw0y+AF/XsO62HE0PYURPdYnwJ41i3fSVA7SA0tZlfTKTh wzvtKI20OiJO41p5NWLbfDWl/Il7pDYkzhrLM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ZapGkotNSXYqMpXwKz1E2EYMQRudgnyMpBdo417DOU38Lpmp5STHA0fqIF2M84Q0xP oazmMOM4RaF8Y9fh53P/KPTALrtpuYrrkKVeXStXwnwplzzl+mQqNROgk3nKEGtbnuMc /7lc2+ayivLKoI9DygtNE4WHRB2tChZlavYmg= MIME-Version: 1.0 Received: by 10.216.11.203 with SMTP id 53mr2728958wex.15.1291413392965; Fri, 03 Dec 2010 13:56:32 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Fri, 3 Dec 2010 13:56:32 -0800 (PST) In-Reply-To: <201012032154.oB3LsADC035461@svn.freebsd.org> References: <201012032154.oB3LsADC035461@svn.freebsd.org> Date: Fri, 3 Dec 2010 13:56:32 -0800 X-Google-Sender-Auth: FT2GsXJImv6Tw1u96hF6B0oI_wA Message-ID: From: Garrett Cooper To: Jung-uk Kim Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216161 - in head/sys: amd64/amd64 i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 21:56:37 -0000 On Fri, Dec 3, 2010 at 1:54 PM, Jung-uk Kim wrote: > Author: jkim > Date: Fri Dec =A03 21:54:10 2010 > New Revision: 216161 > URL: http://svn.freebsd.org/changeset/base/216161 > > Log: > =A0Explicitly initialize TSC frequency. =A0To calibrate TSC frequency, we= use > =A0DELAY(9) and it may use TSC in turn if TSC frequency is non-zero. > > =A0MFC after: =A0 =A03 days > > Modified: > =A0head/sys/amd64/amd64/tsc.c > =A0head/sys/i386/i386/tsc.c > > Modified: head/sys/amd64/amd64/tsc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/amd64/amd64/tsc.c =A0Fri Dec =A03 21:52:01 2010 =A0 =A0 =A0 = =A0(r216160) > +++ head/sys/amd64/amd64/tsc.c =A0Fri Dec =A03 21:54:10 2010 =A0 =A0 =A0 = =A0(r216161) > @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$"); > > =A0#include "cpufreq_if.h" > > -uint64_t =A0 =A0 =A0 tsc_freq; > +uint64_t =A0 =A0 =A0 tsc_freq =3D 0; > =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_broken; > =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_invariant; > =A0static eventhandler_tag tsc_levels_tag, tsc_pre_tag, tsc_post_tag; > > Modified: head/sys/i386/i386/tsc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/i386/i386/tsc.c =A0 =A0Fri Dec =A03 21:52:01 2010 =A0 =A0 = =A0 =A0(r216160) > +++ head/sys/i386/i386/tsc.c =A0 =A0Fri Dec =A03 21:54:10 2010 =A0 =A0 = =A0 =A0(r216161) > @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$"); > > =A0#include "cpufreq_if.h" > > -uint64_t =A0 =A0 =A0 tsc_freq; > +uint64_t =A0 =A0 =A0 tsc_freq =3D 0; > =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_broken; > =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_invariant; > =A0u_int =A0 =A0 =A0 =A0 =A0tsc_present; This is unnecessary. Global values (like this) are initialized to 0 by default: $ cat ~/test_global.c #include int aglobal; int main(void) { printf("%d\n", aglobal); return 0; } $ ~/test_global 0 Thanks, -Garrett