From owner-freebsd-ports@FreeBSD.ORG Mon Sep 19 12:47:26 2011 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6265106564A for ; Mon, 19 Sep 2011 12:47:26 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-wy0-f178.google.com (mail-wy0-f178.google.com [74.125.82.178]) by mx1.freebsd.org (Postfix) with ESMTP id 7B4268FC22 for ; Mon, 19 Sep 2011 12:47:26 +0000 (UTC) Received: by wyf23 with SMTP id 23so6614478wyf.37 for ; Mon, 19 Sep 2011 05:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:reply-to:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/iBZ1Dlwr8t4LP5TlSKKigYmLCbRtr/DNFVk6oslpU0=; b=ljLj/kn7nc0uYD8Q2KLNEX+SmmfnGGbr9TTL/3wpMrBZF/MY5TWkjajUI3yNE2Senr J8NJ4/MRlSKfodIVqbMiUr4DsvzwitQ0cDevpnGTZCN6NbFDu1Qak+NjGLQxPnexqtko 0ta0TDmdwqn/+bGkVN+PaOJMtZr/AW1vSw1yw= MIME-Version: 1.0 Received: by 10.227.19.141 with SMTP id a13mr2738902wbb.62.1316436445236; Mon, 19 Sep 2011 05:47:25 -0700 (PDT) Received: by 10.180.100.1 with HTTP; Mon, 19 Sep 2011 05:47:25 -0700 (PDT) Date: Mon, 19 Sep 2011 08:47:25 -0400 Message-ID: From: "b. f." To: freebsd-ports@FreeBSD.org, "Conrad J. Sabatier" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: Ports with CPPFLAGS in CONFIGURE_(ARGS|ENV) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf1783@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2011 12:47:27 -0000 > > > Do you mean one gigantic, monolithic patch that would amend all of > > > them, or a large set of individual patches (last I checked, there > > > were ~1453 ports in need of this sort of revision)? =C2=A0I could go > > > either way, just need to know which would be preferred. > > > > One monolithic patch (preferably generated with "cvs diff -Nu") > > OK. Just a few more questions: > > portlint -A issues no warning in the case of CPPFLAGS being added to > CONFIGURE_ARGS. Should I concern myself only with CONFIGURE_ENV, or > would it be best to modify in either case? Either case. There are slight differences in the handling of variables passed in the environment (as is done by default for CPPFLAGS), and variables passed on the command-line (as is done for variables assigned in CONFIGURE_ARGS), but they are usually unimportant. Most occurrences of CPPFLAGS in CONFIGURE_ARGS are either mistakes or anachronisms. > > Also, is there any possibility of either CONFIGURE_ENV or > CONFIGURE_ARGS being used in some non-standard fashion, i.e., with > anything other than a GNU configure script, meaning they should just be > left alone? Of course that is possible, although such a usage would probably be rare, i= f it occurs at all. You should only be concerned about the case when: --HAS_CONFIGURE is defined (note that HAS_CONFIGURE can be implied by other things, like GNU_CONFIGURE, XORG_CAT, USE_AUTOTOOLS, USE_PHPIZE, and USE_PHPEXT); and --the default "do-configure" target has not been overridden; because that is when CPPFLAGS is passed in the environment to the configure script. See bsd.port.mk. b.