From owner-cvs-all@FreeBSD.ORG  Thu Jul 31 02:45:08 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50A4937B401; Thu, 31 Jul 2003 02:45:08 -0700 (PDT)
Received: from fafoe.narf.at (chello212186121237.14.vie.surfer.at
	[212.186.121.237])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6B39F43F85; Thu, 31 Jul 2003 02:45:07 -0700 (PDT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.2.102])
	by fafoe.narf.at (Postfix) with ESMTP
	id CB9C03FC4; Thu, 31 Jul 2003 11:45:04 +0200 (CEST)
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 014635E; Thu, 31 Jul 2003 11:45:03 +0200 (CEST)
Date: Thu, 31 Jul 2003 11:45:03 +0200
From: Stefan Farfeleder <stefan@fafoe.narf.at>
To: Scott Long <scottl@FreeBSD.org>
Message-ID: <20030731094503.GQ563@wombat.fafoe.narf.at>
References: <200307310534.h6V5YK4B017415@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200307310534.h6V5YK4B017415@repoman.freebsd.org>
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 busdma_machdep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2003 09:45:08 -0000

On Wed, Jul 30, 2003 at 10:34:20PM -0700, Scott Long wrote:

>   Fixing this bug means that s/g lists can be arbitrarily long in length, and
>   also removes an ugly GNU-ism from the code.  No API or ABI change is
>   incurred.  Similar changes for other platforms is forthcoming.

@@ -683,11 +694,6 @@ bus_dmamap_load_uio(bus_dma_tag_t dmat, 
 		    int flags)
 {
 	bus_addr_t lastaddr;
-#ifdef __GNUC__
-	bus_dma_segment_t dm_segments[dmat->nsegments];
-#else
-	bus_dma_segment_t dm_segments[BUS_DMAMAP_NSEGS];
-#endif
 	int nsegs, error, first, i;
 	bus_size_t resid;
 	struct iovec *iov;

This ugly GNU-ism is called a variable length array and was standardised
in C99 (this is just FYI, no objections to the changes).

Regards,
Stefan Farfeleder