From owner-cvs-all@FreeBSD.ORG  Thu Jul 14 14:47:37 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C345D16A41C;
	Thu, 14 Jul 2005 14:47:37 +0000 (GMT) (envelope-from tilman@arved.at)
Received: from 21322530218.direct.eti.at (21322530218.direct.eti.at
	[213.225.30.218])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B130343D46;
	Thu, 14 Jul 2005 14:47:35 +0000 (GMT) (envelope-from tilman@arved.at)
Received: from jim.arved.de (localhost [127.0.0.1])
	by 21322530218.direct.eti.at (8.13.3/8.13.1) with ESMTP id
	j6EElX2c062827; Thu, 14 Jul 2005 16:47:33 +0200 (CEST)
	(envelope-from tilman@arved.at)
Received: (from arved@localhost)
	by jim.arved.de (8.13.3/8.13.1/Submit) id j6EElWrY062826;
	Thu, 14 Jul 2005 16:47:32 +0200 (CEST)
	(envelope-from tilman@arved.at)
X-Authentication-Warning: jim.arved.de: arved set sender to tilman@arved.at
	using -f
Date: Thu, 14 Jul 2005 16:47:32 +0200
From: Tilman Linneweh <tilman+2005-07-14@arved.at>
To: Robert Watson <rwatson@freebsd.org>
Message-ID: <20050714144732.GA62728@arved.at>
References: <200507141152.j6EBq6x2065276@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200507141152.j6EBq6x2065276@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 14:47:37 -0000

* Robert Watson [Thu, 14 Jul 2005 at 13:52 GMT]:
> rwatson     2005-07-14 11:52:06 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/sys              malloc.h 
>     sys/kern             kern_malloc.c 
>   Log:

[..]
>   While here:
>   
>   - Bump statistics width to uint64_t, and hard code using fixed-width
>     type in order to be more sure about structure layout in the stream.
>     We allocate and free a lot of memory.
>
[..]   
>| @@ -686,10 +689,10 @@ sysctl_kern_malloc(SYSCTL_HANDLER_ARGS)
>|  			temp_bytes = 0;
>|  
>|  		/*
>| -		 * XXXRW: High-waterwark is no longer easily available, so
>| -		 * we just print '-' for that column.
>| +		 * High-waterwark is no longer easily available, so we just
>| +		 * print '-' for that column.
>|  		 */
>| -		sbuf_printf(&sbuf, "%13s%6lu%6luK       -%9lu",
>| +		sbuf_printf(&sbuf, "%13s%6lu%6luK       -%9llu",
>|  		    mtp->ks_shortdesc,
>|  		    temp_allocs,
>|  		    (temp_bytes + 1023) / 1024,

This does not compile on amd64. 

/usr/src/sys/kern/kern_malloc.c: In function `sysctl_kern_malloc':
/usr/src/sys/kern/kern_malloc.c:699: warning: long long unsigned int format, uint64_t arg (arg 6)

regards
tilman